Thanks to visit codestin.com
Credit goes to github.com

Skip to content

This commit fixes issue #175 (be_empty matcher)#201

Merged
Pazus merged 5 commits intoutPLSQL:developfrom
proldan:develop
Feb 11, 2017
Merged

This commit fixes issue #175 (be_empty matcher)#201
Pazus merged 5 commits intoutPLSQL:developfrom
proldan:develop

Conversation

@proldan
Copy link
Copy Markdown
Contributor

@proldan proldan commented Feb 8, 2017

No description provided.

@Pazus
Copy link
Copy Markdown
Member

Pazus commented Feb 8, 2017

@proldan please check your changes, some tests are failling

if self.data_value is not null then
ut_assert_processor.set_xml_nls_params();
dbms_xmlgen.restartQuery(self.data_value);
dbms_xmlgen.setMaxRows(self.data_value, 100);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maxrows can be set to 1

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Feb 8, 2017

The be_empty matcher should also work for collections (anydata). Can you add that so the matcher is complete?

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Feb 8, 2017

For anydata, if the type is object, the matcher should fail with error that the matcher cannot be used on objects but only on collections.

@proldan
Copy link
Copy Markdown
Contributor Author

proldan commented Feb 9, 2017

@Pazus what tests failed? The ones on the be_empty matcher or other ones? I had some problems installing develop version on my db and scheman and I can't execute some of them...

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Feb 9, 2017

You can see the build for this PR failing
"Some checks have failed"
Click on details and you see the build results

@proldan
Copy link
Copy Markdown
Contributor Author

proldan commented Feb 9, 2017

@jgebal Thanks! The matcher should fail with objects and any other type except sys_refcursor, right?

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Feb 9, 2017

The matches schuld succeed for empty dataset in ref cursor and for empty collecion passed to the matcher as anydata

@proldan
Copy link
Copy Markdown
Contributor Author

proldan commented Feb 10, 2017

Corrected! Travis CI build passed and I added support for collections

@Pazus
Copy link
Copy Markdown
Member

Pazus commented Feb 11, 2017

Thanks, @proldan . Merged.

@Pazus Pazus merged commit ca9dadc into utPLSQL:develop Feb 11, 2017
@Pazus Pazus removed the in progress label Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants