-
Notifications
You must be signed in to change notification settings - Fork 189
This commit fixes issue #175 (be_empty matcher) #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
This commit fixes issue #175 (be_empty matcher)
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| create synonym be_empty for ut_be_empty; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| create or replace type body ut_be_empty as | ||
| /* | ||
| utPLSQL - Version X.X.X.X | ||
| Copyright 2016 - 2017 utPLSQL Project | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"): | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| member procedure init(self in out nocopy ut_be_empty) is | ||
| begin | ||
| self.name := 'be_empty'; | ||
| end; | ||
|
|
||
| constructor function ut_be_empty(self in out nocopy ut_be_empty) return self as result is | ||
| begin | ||
| init(); | ||
| return; | ||
| end; | ||
|
|
||
| overriding member function run_matcher(self in out nocopy ut_be_empty, a_actual ut_data_value) return boolean is | ||
| l_result boolean; | ||
| begin | ||
| if a_actual is of (ut_data_value_refcursor) then | ||
| declare | ||
| l_actual ut_data_value_refcursor := treat(a_actual as ut_data_value_refcursor); | ||
| begin | ||
| if l_actual.data_value is not null then | ||
| l_result := l_actual.is_empty; | ||
| else | ||
| l_result := false; | ||
| end if; | ||
| end; | ||
| else | ||
| l_result := (self as ut_matcher).run_matcher(a_actual); | ||
| end if; | ||
| return l_result; | ||
| end; | ||
|
|
||
| end; | ||
| / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| create or replace type ut_be_empty under ut_matcher( | ||
| /* | ||
| utPLSQL - Version X.X.X.X | ||
| Copyright 2016 - 2017 utPLSQL Project | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"): | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| member procedure init(self in out nocopy ut_be_empty), | ||
| constructor function ut_be_empty(self in out nocopy ut_be_empty) return self as result, | ||
| overriding member function run_matcher(self in out nocopy ut_be_empty, a_actual ut_data_value) return boolean | ||
| ) | ||
| / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @@lib/RunTest.sql "ut_matchers/common/ut.expect.common.be_empty.sql 'select * from dual where 1 = 1' 'ut_utils.tr_failure'" | ||
| @@lib/RunTest.sql "ut_matchers/common/ut.expect.common.be_empty.sql 'select * from dual where 1 <> 1' 'ut_utils.tr_success'" | ||
|
|
||
| @@lib/RunTest.sql "ut_matchers/common/ut.expect.common.not_to_be_empty.sql 'select * from dual where 1 = 1' 'ut_utils.tr_success'" | ||
| @@lib/RunTest.sql "ut_matchers/common/ut.expect.common.not_to_be_empty.sql 'select * from dual where 1 <> 1' 'ut_utils.tr_failure'" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --Arrange | ||
| declare | ||
| l_cursor sys_refcursor; | ||
| l_result integer; | ||
| l_asserts_results ut_assert_results; | ||
| begin | ||
| --Act | ||
| open l_cursor for &&1; | ||
| ut.expect(l_cursor).to_be_empty(); | ||
| l_asserts_results := ut_assert_processor.get_asserts_results(); | ||
| l_result := l_asserts_results(l_asserts_results.last).result; | ||
| --Assert | ||
| if l_result = &&2 then | ||
| :test_result := ut_utils.tr_success; | ||
| else | ||
| :test_result := ut_utils.tr_failure; | ||
| dbms_output.put_line('expected: '''||&&2||''', got: '''||l_result||'''' ); | ||
| end if; | ||
| end; | ||
| / |
20 changes: 20 additions & 0 deletions
20
tests/ut_matchers/common/ut.expect.common.not_to_be_empty.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --Arrange | ||
| declare | ||
| l_cursor sys_refcursor; | ||
| l_result integer; | ||
| l_asserts_results ut_assert_results; | ||
| begin | ||
| --Act | ||
| open l_cursor for &&1; | ||
| ut.expect(l_cursor).not_to(be_empty()); | ||
| l_asserts_results := ut_assert_processor.get_asserts_results(); | ||
| l_result := l_asserts_results(l_asserts_results.last).result; | ||
| --Assert | ||
| if l_result = &&2 then | ||
| :test_result := ut_utils.tr_success; | ||
| else | ||
| :test_result := ut_utils.tr_failure; | ||
| dbms_output.put_line('expected: '''||&&2||''', got: '''||l_result||'''' ); | ||
| end if; | ||
| end; | ||
| / |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maxrows can be set to 1