Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bag fix#249

Merged
Pazus merged 3 commits intoutPLSQL:developfrom
Mikhail5544:bag_fix
Mar 29, 2017
Merged

bag fix#249
Pazus merged 3 commits intoutPLSQL:developfrom
Mikhail5544:bag_fix

Conversation

@Mikhail5544
Copy link
Copy Markdown

@Mikhail5544 Mikhail5544 commented Mar 27, 2017

source bag:
ORA-06512: на "SYS.DBMS_LOB", line 1146
ORA-06512: на "UT3.UT_EXECUTABLE", line 88
ORA-06512: на "UT3.UT_EXECUTABLE", line 135
ORA-06512: на "UT3.UT_EXECUTABLE", line 65
ORA-06512: на "UT3.UT_TEST", line 76
ORA-06512: на "UT3.UT_SUITE_ITEM", line 48
ORA-06512: на "UT3.UT_SUITE", line 74
ORA-06512: на "UT3.UT_RUN", line 41
ORA-06512: на "UT3.UT_SUITE_ITEM", line 48
ORA-06512: на "UT3.UT_RUNNER", line 34

ORA-06502: PL/SQL: ошибка числа или значения

Pazus
Pazus suggested changes Mar 27, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@Pazus Pazus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Could you move the second writeappend out of the IF statement as if the initial output contains an empty line we should leave it the same. Otherwise we cutoff all the emptylines.

bag fix
20c644d 
source bag:
ORA-06512: на  "SYS.DBMS_LOB", line 1146
ORA-06512: на  "UT3.UT_EXECUTABLE", line 88
ORA-06512: на  "UT3.UT_EXECUTABLE", line 135
ORA-06512: на  "UT3.UT_EXECUTABLE", line 65
ORA-06512: на  "UT3.UT_TEST", line 76
ORA-06512: на  "UT3.UT_SUITE_ITEM", line 48
ORA-06512: на  "UT3.UT_SUITE", line 74
ORA-06512: на  "UT3.UT_RUN", line 41
ORA-06512: на  "UT3.UT_SUITE_ITEM", line 48
ORA-06512: на  "UT3.UT_RUNNER", line 34

ORA-06502: PL/SQL:  ошибка числа или значения
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 75.511% when pulling d015fd2 on Mikhail5544:bag_fix into 7f2123f on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 75.511% when pulling 20c644d on Mikhail5544:bag_fix into 7f2123f on utPLSQL:develop.

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Mar 27, 2017

It looks good. Thank you @Mikhail5544
Would you be able to create a Unit Test to reproduce the issue and prove that the fix is working?

@Pazus Pazus added this to the version3 milestone Mar 27, 2017
@Pazus Pazus added the bugfix label Mar 27, 2017
@jgebal
Copy link
Copy Markdown
Member

jgebal commented Mar 28, 2017

@Mikhail5544 if you need any support in writing tests, reach out to me or @Pazus , we will be glad to help

@Mikhail5544
Copy link
Copy Markdown
Author

Mikhail5544 commented Mar 29, 2017

@Pazus helped me with writing UT. Please, review it. :)

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 29, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 75.34% when pulling feb77d3 on Mikhail5544:bag_fix into 7f2123f on utPLSQL:develop.

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Mar 29, 2017

Nice solution.
It would be best to see more of our tests rewritten to use the framework to test itself.

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Mar 29, 2017

You will need to update your branch from main develop as there were some other changes and it can't be merged. Can you do that?
I'd like this change to be included in the beta release.

@Pazus
Copy link
Copy Markdown
Member

Pazus commented Mar 29, 2017

I've updated the branch using web.

@Pazus
Copy link
Copy Markdown
Member

Pazus commented Mar 29, 2017

Approved. Will merge after successful build.
Thank you @Mikhail5544 for the contribution and a well defined change!

@jgebal
Copy link
Copy Markdown
Member

jgebal commented Mar 29, 2017

Great work. Thanks for collaborating on it.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 29, 2017

Coverage Status

Coverage increased (+0.01%) to 75.34% when pulling e23b7c2 on Mikhail5544:bag_fix into e14739e on utPLSQL:develop.

2 similar comments
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 29, 2017

Coverage Status

Coverage increased (+0.01%) to 75.34% when pulling e23b7c2 on Mikhail5544:bag_fix into e14739e on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 29, 2017

Coverage Status

Coverage increased (+0.01%) to 75.34% when pulling e23b7c2 on Mikhail5544:bag_fix into e14739e on utPLSQL:develop.

@Pazus Pazus merged commit 361f007 into utPLSQL:develop Mar 29, 2017
@Pazus Pazus removed the in progress label Mar 29, 2017
@Mikhail5544 Mikhail5544 deleted the bag_fix branch March 29, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Pazus Pazus Pazus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mikhail5544 Mikhail5544

Labels

bugfix

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Mikhail5544 @coveralls @jgebal @Pazus @PaulWalkerUK