Fix error with space before annotation params#375
Merged
jgebal merged 9 commits intoutPLSQL:developfrom Jul 4, 2017
Merged
Conversation
jgebal
requested changes
Jun 29, 2017
| end if; | ||
|
|
||
| if l_annotation_data.package_annotations.exists('suitepath') then | ||
| if l_annotation_data.package_annotations.exists('suitepath') and trim(l_annotation_data.package_annotations('suitepath').text) is not null then |
Member
There was a problem hiding this comment.
I think that the trim should be done on the text of annotation param inside the annotation parser.
| --act | ||
| l_objects_to_run := ut_suite_manager.configure_execution_by_path(ut_varchar2_list('tst_empty_suite_path')); | ||
|
|
||
| if ut_expectation_processor.get_status = ut_utils.tr_success then |
Member
There was a problem hiding this comment.
I don't understand how will this test ever fail, as there is no expectation executed before status is checked.
|
|
||
| --Assert | ||
| l_ann_param := null; | ||
| l_ann_param.val := 'Name of suite'; |
Member
There was a problem hiding this comment.
Lines 24 and 25 are not used I think
| c_annotation_block_pattern constant varchar2(200) := '(({COMMENT#.+}'||chr(10)||')+)( |'||chr(09)||')*(procedure|function)\s+(' || | ||
| c_rgexp_identifier || ')'; | ||
| c_annotation_pattern constant varchar2(50) := gc_annotation_qualifier || c_rgexp_identifier || '(\(.*?\)$)?'; | ||
| c_annotation_pattern constant varchar2(50) := gc_annotation_qualifier || c_rgexp_identifier || '[ '||chr(9)||']*(\(.*?\)$)?'; |
Member
There was a problem hiding this comment.
Shouldn't we use \s* rather than chr(9)?
We should also enhance the pattern to allow \s at the end I think.
So how about:
gc_annotation_qualifier || c_rgexp_identifier || '\s*(\(.*?\)\s*$)?';
Member
Author
There was a problem hiding this comment.
\s contains new line character which is not allowed
Member
There was a problem hiding this comment.
Can you make the regexp work with trailing spaces?
'[ '||chr(9)||]((.?)[ '||chr(9)||']*$)?'
fixed additional recent tests
jgebal
requested changes
Jul 2, 2017
| c_annotation_block_pattern constant varchar2(200) := '(({COMMENT#.+}'||chr(10)||')+)( |'||chr(09)||')*(procedure|function)\s+(' || | ||
| c_rgexp_identifier || ')'; | ||
| c_annotation_pattern constant varchar2(50) := gc_annotation_qualifier || c_rgexp_identifier || '(\(.*?\)$)?'; | ||
| c_annotation_pattern constant varchar2(50) := gc_annotation_qualifier || c_rgexp_identifier || '[ '||chr(9)||']*(\(.*?\)$)?'; |
Member
There was a problem hiding this comment.
Can you make the regexp work with trailing spaces?
'[ '||chr(9)||]((.?)[ '||chr(9)||']*$)?'
1 similar comment
1 similar comment
1 similar comment
1 similar comment
2 similar comments
jgebal
approved these changes
Jul 4, 2017
Pazus
added a commit
that referenced
this pull request
Jul 18, 2017
### Documentation #399 Documentation now refers to [migration](https://github.com/utPLSQL/utPLSQL-v2-v3-migration) project #386 Documentation now refers to a valid object name: `ut_file_mapping` #362 Install and Uninstall scripts are now much more readable #361 Install guide now provides snippet on how to download latest release on Windows ### Installation #396 Added override user/password/tablespace for install_headless #384 Installation is now smooth even if profiler tables already exist ### Internal improvements #388 Improved reporting from RunTest #363 Fixed publishing of release documentation history ### Improvements and fixes #407 Fixed rare issue with `ORA-22813: operand value exceeds system limits` #403 Stack trace is now properly parsed on all machines #397 The `--%disabled` annotation on suite level is now reporting all tests as disabled #395 Coverage reporting is now properly filtering test packages on that use suitepath #390 Line of code for failed expectation is now also shown for unit tests owned by other users #380 Line no of failed test is now properly reported when using `ut.fail` #375 Annotation parameter list can now have spaces before/after brackets #373 Warnings in documentation reporter are now properly numbered #372 Documentation reporter is now providing a timing information for each test #370 by xUnit reporter now displays name of the package/procedure if suite/test has no description #369 Fixed errors with multi-byte characters in conversion from/to clob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #357