Merged
Conversation
Now version is bumped on every commit to `develop` and `release/vX.X.Xsomething` branch. Files are no longer blocked from getting downloaded from github. Version is not updated in all files, only in `ut_utils` and `VERSION` file. For develop branch, the version is automatically set to be: - `vX.Y.Z-develop` in VERSION file - `vX.Y.Z.B-develop` in `ut_utils` When building on a release branch, the version is automatically be derived from **release branch name** and the `-develop` suffix is not added for release branches.
pesse
approved these changes
Nov 29, 2017
Member
pesse
left a comment
There was a problem hiding this comment.
Looks great, I like especiall the improved commenting
Pazus
approved these changes
Nov 29, 2017
Member
Pazus
left a comment
There was a problem hiding this comment.
I like the new clean approach!
Well done, Jacek.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now version is bumped on every commit to
developandrelease/vX.X.Xsomethingbranch.Files are no longer blocked from getting downloaded from github.
Version is not updated in all files, only in
ut_utilsandVERSIONfile.For develop branch, the version is automatically set to be:
vX.Y.Z-developin VERSION filevX.Y.Z.B-developinut_utilsWhen building on a release branch, the version is automatically be derived from release branch name and the
-developsuffix is not added for release branches.