Feature/additional asserts#55
Merged
jgebal merged 3 commits intoutPLSQL:version3from Oct 2, 2016
Merged
Conversation
jgebal
reviewed
Oct 1, 2016
| end; | ||
|
|
||
| -- Strings assertions | ||
| procedure str_like(a_msg in varchar2, a_checking_string in varchar2, a_mask in varchar, a_escape_char in varchar2) is |
Member
There was a problem hiding this comment.
maybe is_like or is_matching instead of str_like and a_actual instead of a_checking_string, to keep it consistent with the rest of asserts.
| str_like(a_msg => null, a_checking_string => a_checking_string, a_mask => a_mask); | ||
| end; | ||
|
|
||
| procedure regexp_like(a_msg in varchar2, a_srcstr in varchar2, a_pattern in varchar2, a_modifier in varchar2 default null) is |
Member
There was a problem hiding this comment.
can you change the name of a_srcstr
|
|
||
| procedure this(a_condition in boolean); | ||
| procedure this(a_msg in varchar2, a_condition in boolean); | ||
| -- Strings assertions |
Member
There was a problem hiding this comment.
How about.
--pattern matching assertions
| @@lib/RunTest.sql ut_assert/ut_assert.are_equal.varchar2.GivesFailureWhenBothAreNull.sql | ||
| @@lib/RunTest.sql ut_assert/ut_assert.are_equal.varchar2.GivesFailureWhenExpectedIsNull.sql | ||
| @@lib/RunTest.sql ut_assert/ut_assert.are_equal.varchar2.GivesSuccessForEqualValues.sql | ||
| @@lib/RunTest.sql ut_assert/ut_assert.are_equal.varchar2.GivesSuccessForLikeString.sql |
Member
There was a problem hiding this comment.
Wrong file names, should be: ut_assert.str_like.varchar2...
Member
There was a problem hiding this comment.
Can you add tests proving that assertions are capable of failing?
Member
There was a problem hiding this comment.
Can you add tests for the regexp_like assertion?
Member
Author
|
@jgebal Made requested changed |
…reats the installer file as command window. Added two new assertions: str_like and regexp_like Reordered declaration of the assertion procedures to enforce users to use implementation with assert description provided Added tests for the new asserts
Added tests for regexp_like added failure tests
271b268 to
49c9c32
Compare
Member
Author
|
fixed |
Shoelace
pushed a commit
to Shoelace/utPLSQL
that referenced
this pull request
Oct 3, 2016
* Fixed tests failing due to NLS setting * Added prompt to the first line of the installer so PL/SQL Developer treats the installer file as command window. * Added two new assertions: str_like and regexp_like * Reordered declaration of the assertion procedures to enforce users to use implementation with assert description provided * Added tests for the new asserts * Changes according to @jgebal comments Added tests for regexp_like added failure tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed tests failing due to NLS setting (in RUSSIAN_CIS NLS the delimiter is ",")
Added prompt to the first line of the installer so PL/SQL Developer treats the installer file as command window.
Added two new assertions: str_like and regexp_like
Reordered declaration of the assertion procedures to enforce users to use implementation with assert description provided
Added tests for the new asserts