Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update issue with xml special chars in failure. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 1 commit into from
May 12, 2018
Merged

Update issue with xml special chars in failure. #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions source/reporters/ut_junit_reporter.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,15 @@ create or replace type body ut_junit_reporter is
self.print_text('</error>');
elsif a_test.result > ut_utils.gc_success then
self.print_text('<failure>');
self.print_text(c_cddata_tag_start);
for i in 1 .. a_test.failed_expectations.count loop

l_lines := a_test.failed_expectations(i).get_result_lines();

for j in 1 .. l_lines.count loop
self.print_text(dbms_xmlgen.convert(l_lines(j)));
end loop;
self.print_text(a_test.failed_expectations(i).caller_info);
self.print_text(dbms_xmlgen.convert(a_test.failed_expectations(i).caller_info));
end loop;
self.print_text(c_cddata_tag_end);
self.print_text('</failure>');
end if;
-- TODO - decide if we need/want to use the <system-err/> tag too
Expand Down
2 changes: 0 additions & 2 deletions source/reporters/ut_sonar_test_reporter.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,12 @@ create or replace type body ut_sonar_test_reporter is
self.print_text('</error>');
elsif a_test.result > ut_utils.gc_success then
self.print_text('<failure message="some expectations have failed">');
self.print_text('<![CDATA[');
for i in 1 .. a_test.failed_expectations.count loop
l_lines := a_test.failed_expectations(i).get_result_lines();
for i in 1 .. l_lines.count loop
self.print_text(dbms_xmlgen.convert(l_lines(i)));
end loop;
end loop;
self.print_text(']]>');
self.print_text('</failure>');
end if;
self.print_text('</testCase>');
Expand Down
4 changes: 1 addition & 3 deletions source/reporters/ut_tfs_junit_reporter.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,13 @@ create or replace type body ut_tfs_junit_reporter is
-- Do not count error as failure
elsif a_test.result = ut_utils.gc_failure then
self.print_text('<failure type="failure" message="Test '||a_test.name||' failed">');
self.print_text('<![CDATA[');
for i in 1 .. a_test.failed_expectations.count loop
l_lines := a_test.failed_expectations(i).get_result_lines();
for j in 1 .. l_lines.count loop
self.print_text(dbms_xmlgen.convert(l_lines(j)));
end loop;
self.print_text(a_test.failed_expectations(i).caller_info);
self.print_text(dbms_xmlgen.convert(a_test.failed_expectations(i).caller_info));
end loop;
self.print_text(']]>');
self.print_text('</failure>');
end if;

Expand Down
6 changes: 2 additions & 4 deletions test/core/reporters/test_junit_reporter.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ create or replace package body test_junit_reporter as
from table(ut3.ut.run('check_junit_reporting',ut3.ut_junit_reporter()));
l_actual := ut3.ut_utils.table_to_clob(l_results);
--Assert
ut.expect(l_actual).to_be_like('%at "%.CHECK_JUNIT_REPORTING%", line %');
ut.expect(l_actual).to_be_like('%at &quot;%.CHECK_JUNIT_REPORTING%&quot;, line %');
end;

procedure check_classname_suite is
Expand Down Expand Up @@ -305,9 +305,7 @@ create or replace package body test_junit_reporter as
from table(ut3.ut.run('check_fail_escape',ut3.ut_junit_reporter()));
l_actual := ut3.ut_utils.table_to_clob(l_results);
--Assert
ut.expect(l_actual).to_be_like('%<![CDATA[%
Actual: &apos;test&apos; (varchar2) was expected to equal: &apos;&lt;![CDATA[some stuff]]&gt;&apos; (varchar2)%
]]>%');
ut.expect(l_actual).to_be_like('%Actual: &apos;test&apos; (varchar2) was expected to equal: &apos;&lt;![CDATA[some stuff]]&gt;&apos; (varchar2)%');
end;

procedure check_classname_is_populated is
Expand Down
6 changes: 2 additions & 4 deletions test/core/reporters/test_tfs_junit_reporter.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ create or replace package body test_tfs_junit_reporter as
from table(ut3.ut.run('check_junit_reporting',ut3.ut_tfs_junit_reporter()));
l_actual := ut3.ut_utils.table_to_clob(l_results);
--Assert
ut.expect(l_actual).to_be_like('%at "%.CHECK_JUNIT_REPORTING%", line %');
ut.expect(l_actual).to_be_like('%at &quot;%.CHECK_JUNIT_REPORTING%&quot;, line %');
end;

procedure check_classname_suite is
Expand Down Expand Up @@ -173,9 +173,7 @@ create or replace package body test_tfs_junit_reporter as
from table(ut3.ut.run('check_fail_escape',ut3.ut_tfs_junit_reporter()));
l_actual := ut3.ut_utils.table_to_clob(l_results);
--Assert
ut.expect(l_actual).to_be_like('%<![CDATA[%
Actual: &apos;test&apos; (varchar2) was expected to equal: &apos;&lt;![CDATA[some stuff]]&gt;&apos; (varchar2)%
]]>%');
ut.expect(l_actual).to_be_like('%Actual: &apos;test&apos; (varchar2) was expected to equal: &apos;&lt;![CDATA[some stuff]]&gt;&apos; (varchar2)%');
end;

procedure check_classname_suitepath is
Expand Down