Output buffer&reporters performance improvements

utPLSQL · jgebal · Nov 18, 2018 · Oct 30, 2018 · Nov 2, 2018 · Nov 4, 2018
commit 64dfb41ab3ca8165ca976c0ab9624820ee7b8692
diff --git a/source/core/output_buffers/ut_output_buffer_base.tps b/source/core/output_buffers/ut_output_buffer_base.tps
@@ -20,6 +20,7 @@ create or replace type ut_output_buffer_base authid definer as object(
   member procedure init(self in out nocopy ut_output_buffer_base),
   not instantiable member procedure close(self in ut_output_buffer_base),
   not instantiable member procedure send_line(self in ut_output_buffer_base, a_text varchar2),
+  not instantiable member procedure send_lines(self in ut_output_buffer_base, a_text_list ut_varchar2_rows),
   not instantiable member function get_lines(a_initial_timeout natural := null, a_timeout_sec natural := null) return ut_varchar2_rows pipelined,
   not instantiable member function get_lines_cursor(a_initial_timeout natural := null, a_timeout_sec natural := null) return sys_refcursor,
   not instantiable member procedure lines_to_dbms_output(self in ut_output_buffer_base, a_initial_timeout natural := null, a_timeout_sec natural := null)

diff --git a/source/core/output_buffers/ut_output_table_buffer.tpb b/source/core/output_buffers/ut_output_table_buffer.tpb
@@ -47,16 +47,15 @@ create or replace type body ut_output_table_buffer is
   end;
 
   overriding member procedure send_line(self in ut_output_table_buffer, a_text varchar2) is
-    l_text_list  ut_varchar2_rows;
     pragma autonomous_transaction;
   begin
     if a_text is not null then
       if length(a_text) > ut_utils.gc_max_storage_varchar2_len then
-        l_text_list := ut_utils.convert_collection(ut_utils.clob_to_table(a_text, ut_utils.gc_max_storage_varchar2_len));
-        insert
-          into ut_output_buffer_tmp(output_id, message_id, text)
-        select self.output_id, ut_message_id_seq.nextval, t.column_value
-          from table(l_text_list) t;
+        self.send_lines(
+          ut_utils.convert_collection(
+            ut_utils.clob_to_table(a_text, ut_utils.gc_max_storage_varchar2_len)
+          )
+        );
       else
         insert into ut_output_buffer_tmp(output_id, message_id, text)
         values (self.output_id, ut_message_id_seq.nextval, a_text);
@@ -65,6 +64,18 @@ create or replace type body ut_output_table_buffer is
     end if;
   end;
 
+  overriding member procedure send_lines(self in ut_output_table_buffer, a_text_list ut_varchar2_rows) is
+    pragma autonomous_transaction;
+  begin
+    insert into ut_output_buffer_tmp(output_id, message_id, text)
+    select self.output_id, ut_message_id_seq.nextval, t.column_value
+      from table(a_text_list) t
+     where t.column_value is not null;
+
+    commit;
+  end;
+
+
   overriding member function get_lines(a_initial_timeout natural := null, a_timeout_sec natural := null) return ut_varchar2_rows pipelined is
     l_buffer_data        ut_varchar2_rows;
     l_already_waited_for number(10,2) := 0;

diff --git a/source/core/output_buffers/ut_output_table_buffer.tps b/source/core/output_buffers/ut_output_table_buffer.tps
@@ -20,6 +20,7 @@ create or replace type ut_output_table_buffer under ut_output_buffer_base (
   constructor function ut_output_table_buffer(self in out nocopy ut_output_table_buffer, a_output_id raw := null) return self as result,
   overriding member procedure init(self in out nocopy ut_output_table_buffer),
   overriding member procedure send_line(self in ut_output_table_buffer, a_text varchar2),
+  overriding member procedure send_lines(self in ut_output_table_buffer, a_text_list ut_varchar2_rows),
   overriding member procedure close(self in ut_output_table_buffer),
   overriding member function get_lines(a_initial_timeout natural := null, a_timeout_sec natural := null) return ut_varchar2_rows pipelined,
   overriding member function get_lines_cursor(a_initial_timeout natural := null, a_timeout_sec natural := null) return sys_refcursor,

diff --git a/source/core/types/ut_output_reporter_base.tpb b/source/core/types/ut_output_reporter_base.tpb
@@ -46,6 +46,11 @@ create or replace type body ut_output_reporter_base is
     self.output_buffer.send_line(a_text);
   end;
 
+  member procedure print_text_lines(self in out nocopy ut_output_reporter_base, a_text_lines ut_varchar2_rows) is
+  begin
+    self.output_buffer.send_lines(a_text_lines);
+  end;
+
   final member function get_lines(a_initial_timeout natural := null, a_timeout_sec natural) return ut_varchar2_rows pipelined is
   begin
     for i in (select column_value from table(self.output_buffer.get_lines(a_initial_timeout, a_timeout_sec))) loop

diff --git a/source/core/types/ut_output_reporter_base.tps b/source/core/types/ut_output_reporter_base.tps
@@ -22,7 +22,7 @@ create or replace type ut_output_reporter_base under ut_reporter_base(
   overriding member procedure before_calling_run(self in out nocopy ut_output_reporter_base, a_run in ut_run),
 
   member procedure print_text(self in out nocopy ut_output_reporter_base, a_text varchar2),
-
+  member procedure print_text_lines(self in out nocopy ut_output_reporter_base, a_text_lines ut_varchar2_rows),
   member procedure print_clob(self in out nocopy ut_output_reporter_base, a_clob clob),
 
   final member function get_lines(a_initial_timeout natural := null, a_timeout_sec natural := null) return ut_varchar2_rows pipelined,

diff --git a/source/core/ut_utils.pkb b/source/core/ut_utils.pkb
@@ -326,7 +326,51 @@ create or replace package body ut_utils is
     end if;
   end append_to_list;
 
-procedure append_to_clob(a_src_clob in out nocopy clob, a_clob_table t_clob_tab, a_delimiter varchar2:= chr(10)) is
+  procedure append_to_list(a_list in out nocopy ut_varchar2_rows, a_items ut_varchar2_rows) is
+  begin
+    if a_items is not null then
+      if a_list is null then
+        a_list := ut_varchar2_rows();
+      end if;
+      for i in 1 .. a_items.count loop
+        a_list.extend;
+        a_list(a_list.last) := a_items(i);
+      end loop;
+    end if;
+  end;
+
+  procedure append_to_list(a_list in out nocopy ut_varchar2_rows, a_item clob) is
+  begin
+    append_to_list(
+      a_list,
+      convert_collection(
+        clob_to_table( a_item, ut_utils.gc_max_storage_varchar2_len )
+      )
+    );
+  end;
+
+  procedure append_to_list(a_list in out nocopy ut_varchar2_rows, a_item varchar2) is
+    l_items ut_varchar2_rows;
+  begin
+    if a_item is not null then
+      if a_list is null then
+        a_list := ut_varchar2_rows();
+      end if;
+      if length(a_item) > gc_max_storage_varchar2_len then
+        append_to_list(
+          a_list,
+          ut_utils.convert_collection(
+            ut_utils.clob_to_table( a_item, gc_max_storage_varchar2_len )
+          )
+        );
+      else
+        a_list.extend;
+        a_list(a_list.last) := a_item;
+      end if;
+    end if;
+  end append_to_list;
+
+  procedure append_to_clob(a_src_clob in out nocopy clob, a_clob_table t_clob_tab, a_delimiter varchar2:= chr(10)) is
   begin
     if a_clob_table is not null and cardinality(a_clob_table) > 0 then
       if a_src_clob is null then
@@ -522,7 +566,7 @@ procedure append_to_clob(a_src_clob in out nocopy clob, a_clob_table t_clob_tab,
       ||'?>';
   end;
 
-  function trim_list_elements(a_list IN ut_varchar2_list, a_regexp_to_trim in varchar2 default '[:space:]') return ut_varchar2_list is
+  function trim_list_elements(a_list ut_varchar2_list, a_regexp_to_trim varchar2 default '[:space:]') return ut_varchar2_list is
     l_trimmed_list ut_varchar2_list;
     l_index integer;
   begin

diff --git a/source/core/ut_utils.pks b/source/core/ut_utils.pks
@@ -247,6 +247,21 @@ create or replace package ut_utils authid definer is
    */
   procedure append_to_list(a_list in out nocopy ut_varchar2_list, a_item varchar2);
 
+  /**
+   * Append a item to the end of ut_varchar2_rows
+   */
+  procedure append_to_list(a_list in out nocopy ut_varchar2_rows, a_item varchar2);
+
+  /**
+   * Append a item to the end of ut_varchar2_rows
+   */
+  procedure append_to_list(a_list in out nocopy ut_varchar2_rows, a_item clob);
+
+  /**
+   * Append a list of items to the end of ut_varchar2_rows
+   */
+  procedure append_to_list(a_list in out nocopy ut_varchar2_rows, a_items ut_varchar2_rows);
+
   procedure append_to_clob(a_src_clob in out nocopy clob, a_clob_table t_clob_tab, a_delimiter varchar2 := chr(10));
 
   procedure append_to_clob(a_src_clob in out nocopy clob, a_new_data clob);

diff --git a/source/reporters/ut_coverage_cobertura_reporter.tpb b/source/reporters/ut_coverage_cobertura_reporter.tpb
@@ -39,8 +39,7 @@ create or replace type body ut_coverage_cobertura_reporter is
       l_line_no := a_unit_coverage.lines.first;
       if l_line_no is null then
         for i in 1 .. a_unit_coverage.total_lines loop
-          l_file_part := '<line number="'||i||'" hits="0" branch="false"/>'||chr(10);
-          ut_utils.append_to_clob(l_result, l_file_part);
+          ut_utils.append_to_clob(l_result, '<line number="'||i||'" hits="0" branch="false"/>');
         end loop;
       else
         while l_line_no is not null loop
@@ -68,79 +67,83 @@ create or replace type body ut_coverage_cobertura_reporter is
     function get_coverage_xml(
       a_coverage_data ut_coverage.t_coverage,
       a_run ut_run
-    ) return clob is
+    ) return ut_varchar2_rows is
       l_file_part       varchar2(32767);
-      l_result          clob;
+      l_result          ut_varchar2_rows := ut_varchar2_rows();
       l_unit            ut_coverage.t_full_name;
       l_obj_name        ut_coverage.t_object_name;
-      c_coverage_def    constant varchar2(200) := '<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">'||chr(10);
-      c_file_footer     constant varchar2(30) := '</file>'||chr(10);
+      c_coverage_def    constant varchar2(200) := '<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">';
+      c_file_footer     constant varchar2(30) := '</file>';
       c_coverage_footer constant varchar2(30) := '</coverage>';
-      c_sources_footer  constant varchar2(30) := '</sources>'||chr(10);
-      c_packages_footer constant varchar2(30) := '</packages>'||chr(10);
-      c_package_footer  constant varchar2(30) := '</package>'||chr(10);
-      c_class_footer    constant varchar2(30) := '</class>'||chr(10);
-      c_lines_footer    constant varchar2(30) := '</lines>'||chr(10);
+      c_sources_footer  constant varchar2(30) := '</sources>';
+      c_packages_footer constant varchar2(30) := '</packages>';
+      c_package_footer  constant varchar2(30) := '</package>';
+      c_class_footer    constant varchar2(30) := '</class>';
+      c_lines_footer    constant varchar2(30) := '</lines>';
       l_epoch           varchar2(50) := (sysdate - to_date('01-01-1970 00:00:00', 'dd-mm-yyyy hh24:mi:ss')) * 24 * 60 * 60;
       begin
 
-      dbms_lob.createtemporary(l_result,true);
-
-      ut_utils.append_to_clob(l_result, ut_utils.get_xml_header(a_run.client_character_set)||chr(10));
-      ut_utils.append_to_clob(l_result, c_coverage_def);
+      ut_utils.append_to_list( l_result, ut_utils.get_xml_header(a_run.client_character_set) );
+      ut_utils.append_to_list( l_result, c_coverage_def );
 
       --write header
-      l_file_part:= '<coverage line-rate="0" branch-rate="0.0" lines-covered="'||a_coverage_data.covered_lines||'" lines-valid="'||TO_CHAR(a_coverage_data.covered_lines + a_coverage_data.uncovered_lines)||'" branches-covered="0" branches-valid="0" complexity="0" version="1" timestamp="'||l_epoch||'">';
-      ut_utils.append_to_clob(l_result, l_file_part);
+      ut_utils.append_to_list(
+        l_result,
+        '<coverage line-rate="0" branch-rate="0.0" lines-covered="'
+          ||a_coverage_data.covered_lines||'" lines-valid="'
+          ||TO_CHAR(a_coverage_data.covered_lines + a_coverage_data.uncovered_lines)
+          ||'" branches-covered="0" branches-valid="0" complexity="0" version="1" timestamp="'||l_epoch||'">'
+      );
 
 
       --Write sources
       l_unit := a_coverage_data.objects.first;
-      l_file_part := '<sources>'||CHR(10);
-      ut_utils.append_to_clob(l_result, l_file_part);
+      ut_utils.append_to_list( l_result, '<sources>' );
 
        while l_unit is not null loop
-        l_file_part := '<source>'||dbms_xmlgen.convert(l_unit)||'</source>'||chr(10);
-        ut_utils.append_to_clob(l_result, l_file_part);
+        ut_utils.append_to_list(l_result, '<source>'||dbms_xmlgen.convert(l_unit)||'</source>');
         l_unit := a_coverage_data.objects.next(l_unit);
       end loop;
-      ut_utils.append_to_clob(l_result, c_sources_footer);
+      ut_utils.append_to_list(l_result, c_sources_footer);
 
       --write packages
       l_unit := a_coverage_data.objects.first;
-      l_file_part := '<packages>'||CHR(10);
-      ut_utils.append_to_clob(l_result, l_file_part);
+      ut_utils.append_to_list(l_result, '<packages>');
 
       while l_unit is not null loop
         l_obj_name := a_coverage_data.objects(l_unit).name;
-        l_file_part := '<package name="'||dbms_xmlgen.convert(l_obj_name)||'" line-rate="0.0" branch-rate="0.0" complexity="0.0">'||CHR(10);
-        ut_utils.append_to_clob(l_result, l_file_part);
+        ut_utils.append_to_list(
+          l_result,
+          '<package name="'||dbms_xmlgen.convert(l_obj_name)||'" line-rate="0.0" branch-rate="0.0" complexity="0.0">'
+        );
 
-        l_file_part := '<class name="'||dbms_xmlgen.convert(l_obj_name)||'" filename="'||dbms_xmlgen.convert(l_unit)||'" line-rate="0.0" branch-rate="0.0" complexity="0.0">'||CHR(10);
-        ut_utils.append_to_clob(l_result, l_file_part);
+        ut_utils.append_to_list(
+          l_result,
+          '<class name="'||dbms_xmlgen.convert(l_obj_name)||'" filename="'
+            ||dbms_xmlgen.convert(l_unit)||'" line-rate="0.0" branch-rate="0.0" complexity="0.0">'
+        );
 
-        l_file_part := '<lines>'||CHR(10);
-        ut_utils.append_to_clob(l_result, l_file_part);
-
-        dbms_lob.append(l_result,get_lines_xml(a_coverage_data.objects(l_unit)));
+        ut_utils.append_to_list(l_result, '<lines>');
+
+        ut_utils.append_to_list( l_result, get_lines_xml(a_coverage_data.objects(l_unit)) );
 
-        ut_utils.append_to_clob(l_result, c_lines_footer);
-        ut_utils.append_to_clob(l_result, c_class_footer);
-        ut_utils.append_to_clob(l_result, c_package_footer);
+        ut_utils.append_to_list(l_result, c_lines_footer);
+        ut_utils.append_to_list(l_result, c_class_footer);
+        ut_utils.append_to_list(l_result, c_package_footer);
 
         l_unit := a_coverage_data.objects.next(l_unit);
       end loop;
 
-      ut_utils.append_to_clob(l_result, c_packages_footer);
-      ut_utils.append_to_clob(l_result, c_coverage_footer);
+      ut_utils.append_to_list(l_result, c_packages_footer);
+      ut_utils.append_to_list(l_result, c_coverage_footer);
       return l_result;
     end;
   begin
     ut_coverage.coverage_stop();
 
     l_coverage_data := ut_coverage.get_coverage_data(a_run.coverage_options);
 
-    self.print_clob( get_coverage_xml( l_coverage_data, a_run ) );
+    self.print_text_lines( get_coverage_xml( l_coverage_data, a_run ) );
 
     (self as ut_reporter_base).after_calling_run(a_run);
   end;

diff --git a/source/reporters/ut_coverage_html_reporter.tpb b/source/reporters/ut_coverage_html_reporter.tpb
@@ -29,13 +29,12 @@ create or replace type body ut_coverage_html_reporter is
   end;
 
   overriding member procedure after_calling_run(self in out nocopy ut_coverage_html_reporter, a_run in ut_run) as
-    l_report_lines  ut_varchar2_list;
     l_coverage_data ut_coverage.t_coverage;
   begin
     ut_coverage.coverage_stop();
     l_coverage_data := ut_coverage.get_coverage_data(a_run.coverage_options);
 
-    self.print_clob(
+    self.print_text_lines(
         ut_coverage_report_html_helper.get_index(
             a_coverage_data => l_coverage_data,
             a_assets_path   => self.assets_path,