Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfix/issue 891#892

Merged
PhilippSalvisberg merged 2 commits intodevelopfrom
bugfix/issue_891
Apr 2, 2019
Merged

Bugfix/issue 891#892
PhilippSalvisberg merged 2 commits intodevelopfrom
bugfix/issue_891

Conversation

@PhilippSalvisberg
Copy link
Copy Markdown
Member

used to_match instead of to_be_like to make it work on all 11.2.0.4 Oracle Database instances.

@lwasylow
Copy link
Copy Markdown
Member

lwasylow commented Apr 2, 2019

Would not be better to create a new test called it fix_to_bug_891 and make a changes there ?
That way we kept original test behavior but also created and working test/example of workaround for possible issues ?
(and user if required can disable a test in develop ? )

@PhilippSalvisberg
Copy link
Copy Markdown
Member Author

@lwasylow the behavior of the test did not change. It just uses to_match instead of to_be_like. The tests test exactly the same thing. It's a simple solution with minimal impact.

@PhilippSalvisberg
Copy link
Copy Markdown
Member Author

PhilippSalvisberg commented Apr 2, 2019

Please note that the bug kicks in only when comparing CLOB with LIKE using ESCAPE, and even than not in all cases. To avoid that we simply have to use REGEXP_LIKE instead of LIKE with ESCAPE. in this case this means match instead of be_like. It's not really a fix. It's a documented workaround.

@PhilippSalvisberg
Copy link
Copy Markdown
Member Author

Currently we are just lucky to use a 11.2 XE docker image, where this bug does not exist. This solution ensures that it will work even on the most recent 11.2 version. From my point of view this is better than having some tests which need to be manually enabled/disabled.

@lwasylow
Copy link
Copy Markdown
Member

lwasylow commented Apr 2, 2019

Make senses.

@PhilippSalvisberg PhilippSalvisberg merged commit bb52422 into develop Apr 2, 2019
@jgebal jgebal deleted the bugfix/issue_891 branch April 3, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants