Conversation
…/cursor_error_handling
…/cursor_error_handling
jgebal
reviewed
Apr 4, 2019
Removal of unused procedure from expactation_processor Switch to use constant in error message creation Update tests to match full message.
…pearing on local tests or other similar for expected.
…le dont expect a length value against data type but cursor description return a max_len not being null.
jgebal
approved these changes
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more user friendly error when fetch of cursor breaks.
Unfortunately we cant stop execution using only failure message and we dont want to compare cursors when one is broken as results in null to value ( looks odd) so we raise an error.
Fixes #748