Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/simple logging #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pazus merged 14 commits into from
Feb 14, 2019
Merged

Feature/simple logging #121

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0aa366c
Add simple and basic logging
pesse Feb 5, 2019
606aacb
Add some useful information to output
pesse Feb 6, 2019
9e572bd
StringBlock Formatter for nicer log output
pesse Feb 7, 2019
9014771
AppendLine-function
pesse Feb 7, 2019
078b727
Add useful information in RunCommand
pesse Feb 7, 2019
8bdaf0f
Add quiet and debug flags and also a simple debug configuration
pesse Feb 7, 2019
6a7d650
Refactoring
pesse Feb 7, 2019
801484f
Update documentation
pesse Feb 7, 2019
36ac26e
Reporters- and VersionInfo-Command should not log atm
pesse Feb 7, 2019
00c712a
Update src/main/java/org/utplsql/cli/LoggerConfiguration.java
Pazus Feb 11, 2019
053dfc9
Refactoring according to Pazus suggestions
pesse Feb 12, 2019
351c76a
Some more information around used connector and NLS
pesse Feb 14, 2019
0733e11
Separate username/PW from connectstring so it's properly masked in lo…
pesse Feb 14, 2019
2578f8a
Reporters Command should abort when no connection is possible
pesse Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/main/java/org/utplsql/cli/LoggerConfiguration.java 
Co-Authored-By: pesse <[email protected]>
  • Loading branch information
@Pazus @pesse
Pazus and pesse authored Feb 11, 2019
commit 00c712adaabd8b3d9f7e943fa7326e5c8eb9fa27
4 changes: 3 additions & 1 deletion src/main/java/org/utplsql/cli/LoggerConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
import org.utplsql.api.TestRunner;

class LoggerConfiguration {

private LoggerConfiguration() {
throw new UnsupportedOperationException();
}
static void configure(boolean silent, boolean debug) {
Copy link
Copy Markdown
Member

@Pazus Pazus Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use two parameters here? Are all 4 combination of their values valid? Maybe we should accept 3-valued enum?

SILENT, DEFAULT, DEBUG

Copy link
Copy Markdown
Member Author

@pesse pesse Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason is to make it easy to just pass the parameters of the RunCommand to the LoggerConfigurator.
Enum would increase clarity of the LoggerConfigurator class taken alone but not its usage. This way it's clear that logging is depenent on two flags.
If we can increase clarity on the fact that silent is superior to debug, I'd appreciate it.

Copy link
Copy Markdown
Member

@Pazus Pazus Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should. If non flags are passed then default logging is enabled, if silent - non, if debug - debug. And then we end up with 3 levels, set on application level and non of other classes should think about it. Classes just log using appropriate log level (logger.info, logger.debug).

Copy link
Copy Markdown
Member Author

@pesse pesse Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I get you completely right.
You'd like to introduce a 3-leveled ENUM and shift the logic which configuration to take to the RunCommand?
The classes themselves already use appropriate log level, the purpose of the configuration is to either hide or show the log information.

if ( silent )
configureSilent();
Expand Down