Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleaup of test infrastructure #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pesse merged 4 commits into from
Feb 14, 2019
Merged

Cleaup of test infrastructure #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cce9a34
optimize imports, update junit to 5.4, fix visibility of test methods…
Pazus Feb 14, 2019
c060a01
removed unused class
Pazus Feb 14, 2019
722d3d3
made properties final
Pazus Feb 14, 2019
6568089
additional cleanup, fix typos
Pazus Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made properties final
  • Loading branch information
@Pazus
Pazus committed Feb 14, 2019
commit 722d3d39844098e79a43a2112015075eb9c36725
6 changes: 2 additions & 4 deletions src/main/java/org/utplsql/cli/CommandProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,15 @@

public class CommandProvider {

private Map<String, ICommand> commands;
private JCommander jCommander;
private final Map<String, ICommand> commands = new HashMap<>();
private final JCommander jCommander;

public CommandProvider( JCommander jCommander ) {
this.jCommander = jCommander;
init();
}

private void init() {
commands = new HashMap<>();

addCommand(new RunCommand());
addCommand(new VersionInfoCommand());
addCommand(new ReportersCommand());
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/utplsql/cli/ConnectionInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
public class ConnectionInfo {

public static final String COMMANDLINE_PARAM_DESCRIPTION = "<user>/<password>@//<host>[:<port>]/<service> OR <user>/<password>@<TNSName> OR <user>/<password>@<host>:<port>:<SID>";
private String connectionInfo;
private final String connectionInfo;

public ConnectionInfo(String connectionInfo) {
this.connectionInfo = connectionInfo;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/utplsql/cli/HelpCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@
*/
public class HelpCommand implements ICommand {

private String errorMessage;
private JCommander jCommander;
private final String errorMessage;
private final JCommander jCommander;

public HelpCommand(JCommander jCommander) {
this.jCommander = jCommander;
this.errorMessage = null;
}

public HelpCommand( JCommander jCommander, String errorMessage ) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/utplsql/cli/ReporterManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,5 @@ public List<ReporterOptions> getReporterOptionsList() {
return reporterOptionsList;
}

public int getNumberOfReporters() { return reporterOptionsList.size(); };
public int getNumberOfReporters() { return reporterOptionsList.size(); }
}
2 changes: 1 addition & 1 deletion src/main/java/org/utplsql/cli/datasource/TestedDataSourceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ interface ConnectStringPossibility {

private static final Logger logger = LoggerFactory.getLogger(TestedDataSourceProvider.class);
private final ConnectionConfig config;
private List<ConnectStringPossibility> possibilities = new ArrayList<>();
private final List<ConnectStringPossibility> possibilities = new ArrayList<>();

public TestedDataSourceProvider(ConnectionConfig config) {
this.config = config;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/utplsql/cli/log/StringBlockFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
public class StringBlockFormatter {

private String headline;
private StringBuilder content = new StringBuilder();
private final StringBuilder content = new StringBuilder();

public StringBlockFormatter() {}

Expand Down