Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/new cli library #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pesse merged 33 commits into from
Jun 26, 2019
Merged

Feature/new cli library #154

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6717057
Failing test to catch and reproduce #143
pesse Jun 4, 2019
038981f
Merge branch 'develop' into feature/new_cli_library
pesse Jun 7, 2019
b21f651
Unit-Test to simulate passing all parameters that should be known
pesse Jun 7, 2019
ce849fc
Initial implementation of Picocli usage
pesse Jun 11, 2019
5520562
Some more tests around FileMapping
pesse Jun 12, 2019
f9c4cf7
New RunAction which does the logic based on RunCommandConfig
pesse Jun 12, 2019
d8cbce2
RunAction tested and functional so far
pesse Jun 12, 2019
3b5e168
Include RunAction into RunCommand
pesse Jun 12, 2019
60997d7
New entry point for Picocli
pesse Jun 12, 2019
d13ae5b
Extract functionality to interface
pesse Jun 12, 2019
5e86b01
Adapt tests to IRunCommand and implement necessary functionality
pesse Jun 12, 2019
00f3f5f
Change VersionCommand to Picocli
pesse Jun 12, 2019
2ce4e91
Change ReportersCommand to Picocli
pesse Jun 13, 2019
b88d5c5
Fix arity for mapping options and prevent NPE
pesse Jun 13, 2019
c80dc8c
Refactor RunCommandTest to cover new approach
pesse Jun 13, 2019
8eec2cb
Implement rules for printToScreen Reporters: Only one can go to screen
pesse Jun 13, 2019
ded39d3
Implemented new Picocli help
pesse Jun 13, 2019
6922e52
Removed some now unnecessary stuff
pesse Jun 13, 2019
5aa4c1d
We don't need the old RunCommand anymore, time to get rid of it
pesse Jun 13, 2019
60fcfaf
Improve help and help-tests
pesse Jun 13, 2019
a3608b5
Refactor: Remove unnecessary logic
pesse Jun 13, 2019
09bf357
Refactor: extract ReporterConfig -> ReporterOption conversion
pesse Jun 13, 2019
1b65b51
Refactor: getCommand() no longer needed
pesse Jun 13, 2019
77fd752
Refactor: Include only left check-functionality
pesse Jun 13, 2019
e443e3c
Refactor: Cleanup ReporterManager a bit
pesse Jun 13, 2019
0bdca7d
Get rid of JCommander dependency
pesse Jun 13, 2019
ae0e9c4
Move ConnectionString description to main Utplsql-Command
pesse Jun 18, 2019
f47c0de
Fix Typo
pesse Jun 18, 2019
bb18ea1
Some Refactorings and make things final
pesse Jun 18, 2019
1a984ff
Merge branch 'develop' into feature/new_cli_library
pesse Jun 18, 2019
81e0953
Reformatting
pesse Jun 18, 2019
a8acbb9
Add `-h` option to all commands and cover it with tests
pesse Jun 18, 2019
10bef7b
Adjust documentation to reflect parameter changes
pesse Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some Refactorings and make things final
  • Loading branch information
@pesse
pesse committed Jun 18, 2019
commit bb18ea172133553585c31ae654b20254de8dec4b
18 changes: 9 additions & 9 deletions src/main/java/org/utplsql/cli/ReporterManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

class ReporterManager {

private List<ReporterOptions> reporterOptionsList;
private List<Throwable> reporterGatherErrors;
private final List<ReporterOptions> reporterOptionsList;
private List<Exception> reporterGatherErrors;
private ExecutorService executorService;

ReporterManager(ReporterConfig[] reporterConfigs ) {
Copy link
Copy Markdown
Member

@Pazus Pazus Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me share with you my point. I prefere to use simple constructors and use factory methods for all necessary operation neede to call the constructor. I don't like calling functions from a constructor as it doesn't allow making fields final and I personnaly like final fields. Do you mind making a small refactoring of this place?

Copy link
Copy Markdown
Member Author

@pesse pesse Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like

public static ReporterManager create( ReporterConfig[] reporterConfigs ) { ...

?

Copy link
Copy Markdown
Member

@Pazus Pazus Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes with all necessary stuff populating arrays done there and then call a simple private constructor.

Expand Down Expand Up @@ -55,12 +55,12 @@ private ReporterOptions getDefaultReporterOption() {
return new ReporterOptions(CoreReporters.UT_DOCUMENTATION_REPORTER.name());
}

private void abortGathering(Throwable e) {
private void abortGathering(Exception e) {
addGatherError(e);
executorService.shutdownNow();
Copy link
Copy Markdown
Member

@Pazus Pazus Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this might be an issue. We get the executorService from the outside but we shut it down here. I'm concerned if the caller is ok with its executorService been shut down.

Copy link
Copy Markdown
Member Author

@pesse pesse Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually the purpose: If one Reporter Consumption fails, it should abort all the other Reporter threads.
But that's one of the things I want to do differently/more clear

Copy link
Copy Markdown
Member

@Pazus Pazus Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets abort tasks then, not the excutor

Copy link
Copy Markdown
Member Author

@pesse pesse Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will make that more clear in a restructured version

}

private void addGatherError( Throwable e ) {
private void addGatherError( Exception e ) {
if ( reporterGatherErrors == null ) {
reporterGatherErrors = new ArrayList<>();
}
Expand All @@ -71,7 +71,7 @@ boolean haveGatherErrorsOccured() {
return reporterGatherErrors != null && !reporterGatherErrors.isEmpty();
}

List<Throwable> getGatherErrors() {
List<Exception> getGatherErrors() {
return reporterGatherErrors;
}

Expand Down Expand Up @@ -127,11 +127,11 @@ List<ReporterOptions> getReporterOptionsList() {
*/
private static class GatherReporterOutputTask implements Runnable {

private DataSource dataSource;
private ReporterOptions option;
private Consumer<Throwable> abortFunction;
private final DataSource dataSource;
private final ReporterOptions option;
private final Consumer<Exception> abortFunction;

GatherReporterOutputTask( DataSource dataSource, ReporterOptions reporterOption, Consumer<Throwable> abortFunction ) {
GatherReporterOutputTask( DataSource dataSource, ReporterOptions reporterOption, Consumer<Exception> abortFunction ) {

if ( reporterOption.getReporterObj() == null )
throw new IllegalArgumentException("Reporter " + reporterOption.getReporterName() + " is not initialized");
Expand Down