Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/version check #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pesse wants to merge 10 commits into from
Closed

Feature/version check #40

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
abf5256
Very simple fail-fast if DB framework is not compatible
pesse Nov 8, 2017
a514881
Added -scc/--skip-compatibility-check option
pesse Nov 9, 2017
d46bc3f
Update documentation
pesse Nov 9, 2017
091dbea
Merge branch 'develop' of https://github.com/utPLSQL/utPLSQL-cli into…
Nov 10, 2017
34a63e0
Little bit of refactoring
pesse Nov 10, 2017
7617e78
Refactoring aiming for single-responsibility and IOSP
pesse Nov 10, 2017
e32a71d
Just copied the travis settings from api project
pesse Nov 11, 2017
6bb3488
Trial and error. Something's not working yet
pesse Nov 11, 2017
286cdba
Adjusted default run-Test and refactoring
pesse Nov 11, 2017
b4ef181
Removed repo variable
pesse Nov 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Little bit of refactoring 
we don't want to have another open connection, do we?
  • Loading branch information
@pesse
pesse authored and Samuel Nitsche committed Nov 10, 2017
commit 34a63e0cfb0307241dcd460d63a9f40616a58e5a
15 changes: 11 additions & 4 deletions src/main/java/org/utplsql/cli/RunCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ public List<String> getTestPaths() {
public int run() throws Exception {
final ConnectionInfo ci = getConnectionInfo();

// First of all do a compatibility check and fail-fast
checkFrameworkCompatibility(ci);

final List<ReporterOptions> reporterOptionsList = getReporterOptionsList();
final List<String> testPaths = getTestPaths();
Expand All @@ -118,6 +116,10 @@ public int run() throws Exception {

// Do the reporters initialization, so we can use the id to run and gather results.
try (Connection conn = ci.getConnection()) {

// First of all do a compatibility check and fail-fast
checkFrameworkCompatibility(conn);

for (ReporterOptions ro : reporterOptionsList) {
Reporter reporter = ReporterFactory.createReporter(ro.getReporterName());
reporter.init(conn);
Expand Down Expand Up @@ -212,11 +214,16 @@ public List<ReporterOptions> getReporterOptionsList() {
return reporterOptionsList;
}

private void checkFrameworkCompatibility(ConnectionInfo ci) throws SQLException {
/** Checks whether cli is compatible with the database framework
*
* @param conn Active Connection
* @throws SQLException
*/
private void checkFrameworkCompatibility(Connection conn) throws SQLException {

if ( !skipCompatibilityCheck ) {
try {
DBHelper.failOnVersionCompatibilityCheckFailed(ci.getConnection());
DBHelper.failOnVersionCompatibilityCheckFailed(conn);
} catch (DatabaseNotCompatibleException e) {
System.out.println(e.getMessage());

Expand Down