-
Notifications
You must be signed in to change notification settings - Fork 15
Version info and info command in cli #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fbbef6d
Minimal viable (and ugly) solution to add version info to cli
pesse 2772add
First set of refactorings around ConnectionInfo
pesse 457625d
Refactoring around commands.
pesse 3236087
Improved tests for VersionInfoCommand
pesse 6326514
Updated help
pesse feff4a3
Added another command: reporters <ConnectionUrl>
pesse 52d4368
Added documentation
pesse 808a2d6
Some improvements to documentation
pesse 554c71b
Refactoring of ReportersCommand
pesse 93c8e5d
Some more minor refactoring
pesse d402718
Switch table-like to 4-space intendation
pesse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package org.utplsql.cli; | ||
|
||
/** This class is getting updated automatically by the build process. | ||
* Please do not update its constants manually cause they will be overwritten. | ||
* | ||
* @author pesse | ||
*/ | ||
public class CliVersionInfo { | ||
|
||
private static final String BUILD_NO = "local"; | ||
private static final String MAVEN_PROJECT_NAME = "cli"; | ||
private static final String MAVEN_PROJECT_VERSION = "3.1.1-SNAPSHOT"; | ||
|
||
public static String getVersion() { | ||
return MAVEN_PROJECT_VERSION + "." + BUILD_NO; | ||
} | ||
|
||
public static String getInfo() { return MAVEN_PROJECT_NAME + " " + getVersion(); } | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make a separate section for the connection URL and link to it in each command. That way it is defined only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, came to my mind but wasn't able to come up with a good way and therefore decided to refactor later ;)