Bugfix/coverage key value parameter #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pazus
requested changes
Jul 19, 2019
src/main/java/org/utplsql/api/db/DynamicParameterListBuilder.java
Outdated
Show resolved
Hide resolved
| public class DynamicParameterListTest { | ||
|
|
||
| @Test | ||
| void call_with_three_different_types() throws SQLException { |
There was a problem hiding this comment.
You know if you which to create human readable name of a test you can use @Display annotation which will be displayed in the results instead of the method name
There was a problem hiding this comment.
I know, the upside of this approach is that I know immediately what the test does without first having to look for the @Display content.
It's a very good addition, though.
Pazus
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When empty TypeMapping parameter is passed, the java-api should assure it is passed to utPLSQL-api as NULL so the default TypeMapping can kick in.
Fixes utPLSQL/utPLSQL-cli#162
Adds some tests, too, and hides TypeMapper from public. Nothing but the java-api should mess with these internals.