hardlink: logging and performance improvements #3549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that jlog() is a function, all gettext() arguments are evaluated in all cases, including when output is unnecessary due to --quiet or low verbose mode. Fixes: util-linux#3548 Signed-off-by: Karel Zak <[email protected]>
During work on better verbose output, I found a regression between v2.40 and v2.41 (and v2.42). In the new version, hardlink is 3-4 times slower. The problem is in the function where we verify signals. It calls the function signal() even though no signal is delivered. It's called in code loops where hardlink scans files, making it a performance-sensitive area. Another significant performance improvement is using an inline function for handle_interrupt(). This simple patch improves hardlink performance by 10 times. Fixes: http://github.com/util-linux/util-linux/commit/1453200e22dd4ec858be027653c167225f2fb358 Signed-off-by: Karel Zak <[email protected]>
The functions are called many times. Signed-off-by: Karel Zak <[email protected]>
d5b661e to
5ef57d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second patch should also be backported into stable/v2.41 and stable/v2.42.