libmount: non-root mkdir support #3640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karel Zak <[email protected]>
* introduce do_canonicalize() with proper return values * use do_canonicalize() everywhere Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
* add ul_restricted_path_oper() to fileutils.c * use it as backed for canonicalize_path_restricted() Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Based on ul_restricted_path_oper(). Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Based-on: util-linux#3597 Signed-off-by: Karel Zak <[email protected]>
fb3655d to
02f6eb5
Compare
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
* test classic user-mount (mount.static required) * test user-mount with X-mount.mkdir Signed-off-by: Karel Zak <[email protected]>
t-8ch
reviewed
Jul 29, 2025
lib/canonicalize.c
Outdated
| len = canonical ? (ssize_t) strlen(canonical) : | ||
| errno ? -errno : -EINVAL; | ||
| len = canonical ?(ssize_t) strlen(canonical) : | ||
| errno ? -errno : -EINVAL; |
There was a problem hiding this comment.
Spurious whitespace changes? If intentional should be in a dedicated commit.
| if (!path || !*path) | ||
| return NULL; | ||
| if (result) | ||
| *result = NULL; |
There was a problem hiding this comment.
result seems to be always non-NULL.
|
|
||
| errno = 0; |
| * unreachable path is not an error (!), and in this case, it just duplicates | ||
| * @path. | ||
| */ | ||
| char *canonicalize_path(const char *path) |
There was a problem hiding this comment.
Shouldn't these also all get the ul_ prefix?
| fprintf(stdout, "real: %s\n", canonicalize_path(argv[1])); | ||
|
|
||
| fprintf(stdout, "real: %s\n", canonicalize_path(argv[1])); | ||
| fprintf(stdout, "real-restricted: %s\n", canonicalize_path_restricted(argv[1])); |
There was a problem hiding this comment.
Can this be used to have a real unittest which validates the results?
| ts_init_subtest "basic" | ||
| TS_FSTAB="/etc/fstab" | ||
| ts_fstab_add $MOUNT_SOURCE $MOUNT_TARGET "none" "bind,user,default,noauto" | ||
| runuser -u testuser_mount -- $TS_CMD_MOUNT_STATIC $MOUNT_TARGET >> $TS_OUTPUT 2>> $TS_ERRLOG |
There was a problem hiding this comment.
Maybe use the runuser from the current build.
|
|
||
| # Add test user | ||
| # | ||
| useradd -u 9899 --shell /bin/bash testuser_mount |
There was a problem hiding this comment.
Not a fan of this. Can we use nobody?
Or just a random user id from a transient uid range.
| # classic user-mount | ||
| # | ||
| ts_init_subtest "basic" | ||
| TS_FSTAB="/etc/fstab" |
There was a problem hiding this comment.
Is the regular test fstab not enough?
| runuser -u testuser_mount -- $TS_CMD_MOUNT_STATIC $MOUNT_TARGET >> $TS_OUTPUT 2>> $TS_ERRLOG | ||
| opts=$(findmnt -nr -o VFS-OPTIONS --mountpoint $MOUNT_TARGET) | ||
| [[ $opts == *"noexec"* && $opts == *"nosuid"* && $opts == *"nodev"* ]] \ | ||
| || ts_log "Cannot find user options" |
| TS_FSTAB="/etc/fstab" | ||
| ts_fstab_add $MOUNT_SOURCE $MOUNT_TARGET "none" "bind,user,default,noauto" | ||
| runuser -u testuser_mount -- $TS_CMD_MOUNT_STATIC $MOUNT_TARGET >> $TS_OUTPUT 2>> $TS_ERRLOG | ||
| opts=$(findmnt -nr -o VFS-OPTIONS --mountpoint $MOUNT_TARGET) |
|
I'll split this pull request into three separate pull requests:
I'll keep it open as a draw until all is implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.