stat: fix mount table read when /proc is unavailable#10300
Open
sylvestre wants to merge 2 commits intouutils:mainfrom
Open
stat: fix mount table read when /proc is unavailable#10300sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre wants to merge 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Jan 19, 2026
src/uu/stat/src/stat.rs
Outdated
|
|
||
| let mount_list = self.mount_list.get_or_init(|| { | ||
| // Try to populate mount list, but don't fail if we can't | ||
| Self::populate_mount_list().ok() |
Collaborator
There was a problem hiding this comment.
Even if we don't fail it appears that the GNU implementation provides a warning:
sudo unshare --mount sh -c 'mount -t tmpfs none /proc; stat --format="%m" /tmp'
I'm getting: "stat: cannot read table of mounted file systems: No such file or directory"
Only read mount information when needed (%m directive) and handle gracefully when /proc/self/mountinfo is not accessible, fixing stat failures in chroot environments without /proc mounted. see https://bugs.launchpad.net/ubuntu/+source/rust-coreutils/+bug/2133797
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only read mount information when needed (%m directive) and handle gracefully when /proc/self/mountinfo is not accessible, fixing stat failures in chroot environments without /proc mounted.
see https://bugs.launchpad.net/ubuntu/+source/rust-coreutils/+bug/2133797