Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change fuzz_seq_parse_number to should_pass: false #10335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 1 commit into from
Jan 18, 2026
Merged

Change fuzz_seq_parse_number to should_pass: false #10335

sylvestre merged 1 commit into from
Jan 18, 2026

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jan 18, 2026

Fails with:

Failing input:

fuzz/artifacts/fuzz_seq_parse_number/crash-880e3fa1db64b55230dca321d3c6a3aa7c1ad977

Output of std::fmt::Debug:

[48, 120, 55, 46, 48, 48, 49, 49, 48, 48, 48, 48, 48, 48, 48, 112, 45, 54, 56, 48, 48, 48, 49, 49, 49, 48, 48, 49, 53, 55, 57, 49, 55, 55, 55, 91, 55, 105, 110, 102, 105, 110, 105, 116, 121]

Reproduce with:

cargo fuzz run fuzz_seq_parse_number fuzz/artifacts/fuzz_seq_parse_number/crash-880e3fa1db64b55230dca321d3c6a3aa7c1ad977

Minimize test case with:

cargo fuzz tmin fuzz_seq_parse_number fuzz/artifacts/fuzz_seq_parse_number/crash-880e3fa1db64b55230dca321d3c6a3aa7c1ad977

@sylvestre
Change fuzz_seq_parse_number to should_pass: false
0a6a89d 
Fails with:

Failing input:

	fuzz/artifacts/fuzz_seq_parse_number/crash-880e3fa1db64b55230dca321d3c6a3aa7c1ad977

Output of `std::fmt::Debug`:

	[48, 120, 55, 46, 48, 48, 49, 49, 48, 48, 48, 48, 48, 48, 48, 112, 45, 54, 56, 48, 48, 48, 49, 49, 49, 48, 48, 49, 53, 55, 57, 49, 55, 55, 55, 91, 55, 105, 110, 102, 105, 110, 105, 116, 121]

Reproduce with:

	cargo fuzz run fuzz_seq_parse_number fuzz/artifacts/fuzz_seq_parse_number/crash-880e3fa1db64b55230dca321d3c6a3aa7c1ad977

Minimize test case with:

	cargo fuzz tmin fuzz_seq_parse_number fuzz/artifacts/fuzz_seq_parse_number/crash-880e3fa1db64b55230dca321d3c6a3aa7c1ad977
@sylvestre sylvestre merged commit 4e7fa9f into main Jan 18, 2026
195 of 196 checks passed
@sylvestre sylvestre deleted the sylvestre-patch-4 branch January 18, 2026 20:09
@sylvestre sylvestre mentioned this pull request Jan 18, 2026
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 18, 2026

Merging this PR will degrade performance by 3.28%

❌ 1 regressed benchmark
✅ 281 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory dd_copy_partial 129.1 KB 133.5 KB -3.28%

Comparing sylvestre-patch-4 (0a6a89d) with main (2122c52)2

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (1a81d1b) during the generation of this report, so 2122c52 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@moonfruit moonfruit mentioned this pull request Feb 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDryden ChrisDryden ChrisDryden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sylvestre @ChrisDryden