cksum: Add SHA3/SHAKE support and --debug flag #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Contributor
|
Could you please add tests to make sure we don't regress in the future? Thanks |
evilpie
reviewed
Oct 18, 2025
sylvestre
reviewed
Oct 19, 2025
|
GNU testsuite comparison: |
sylvestre
reviewed
Oct 20, 2025
|
GNU testsuite comparison: |
08769f4 to
cbb156c
Compare
Contributor
|
please move the --debug implementation in a different PR |
Contributor
Author
|
sr, i missed pushing the commit from 8949 to 8948 🤡 |
|
GNU testsuite comparison: |
sylvestre
requested changes
Oct 26, 2025
Contributor
sylvestre
left a comment
There was a problem hiding this comment.
still need --debug move away
9016b78 to
514291d
Compare
CodSpeed Performance ReportMerging #8948 will not alter performanceComparing Summary
|
c177dec to
d2ee583
Compare
|
GNU testsuite comparison: |
3a9e52b to
6b1cf16
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
dcb966d to
fd5840a
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Oct 31, 2025
cakebaker
reviewed
Oct 31, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_sha3_with_length() { |
Contributor
There was a problem hiding this comment.
This functionality is already tested by test_sha3_single_file.
cakebaker
reviewed
Oct 31, 2025
naoNao89
added a commit
to naoNao89/coreutils
that referenced
this pull request
Nov 3, 2025
…ack) - Remove test_sha3_with_length() - redundant with test_sha3_single_file() - Remove test_sha3_invalid_length() - redundant with test_sha_length_invalid() and test_sha_missing_length() - Remove test_sha3_untagged() - redundant with test_untagged_sha3_single_file() - Keep test_sha3_base64_output() - provides unique coverage for base64 output with SHA3 Addresses code review feedback from @cakebaker (Oct 31) on PR uutils#8948. All 134 tests pass with no regressions.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
e92cfab to
204d05f
Compare
naoNao89
added a commit
to naoNao89/coreutils
that referenced
this pull request
Nov 3, 2025
This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.
204d05f to
661934b
Compare
|
GNU testsuite comparison: |
This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE - Add --debug flag (no-op matching GNU behavior) Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.
661934b to
dee3483
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for SHA3/SHAKE algorithm support
This PR adds comprehensive test coverage for SHA3 and SHAKE algorithms with the --length parameter.
The SHA3/SHAKE implementation was already merged into main. This PR ensures the algorithms are properly tested with various length parameters and edge cases.
Fixes #8933 (test coverage aspect)