Fix chown tests for FreeBSD and macOS #9058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Contributor
|
much better, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed some of the
chowntests for FreeBSD and for macOS.rootwas hardcoded in some places, but it'swheelon BSD systems.test_chown_only_group, the username is taken and used to set the group of a file. I guess this is a bug and the group name was intended to use here.wheelgroup. That's why setting the file group towheelsucceeds. I have added a check here to see if the user is inwheelalready and if so, to not runchownagain. Because the case where we runchownon the current group is covered already in the very same tests.