Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(cat): refine unsafe overwrite detection for appending files #9122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix(cat): refine unsafe overwrite detection for appending files #9122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/uu/cat/src/platform/unix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,29 @@ pub fn is_unsafe_overwrite<I: AsFd, O: AsFd>(input: &I, output: &O) -> bool {
let Ok(output_info) = FileInformation::from_file(output) else {
return false;
};
if input_info != output_info || output_info.file_size() == 0 {
if input_info != output_info {
return false;
}
if is_appending(output) {
return true;
let file_size = output_info.file_size();
if file_size == 0 {
return false;
}
// `lseek` returns an error if the file descriptor is closed or it refers to
// a non-seekable resource (e.g., pipe, socket, or some devices).
let Ok(input_pos) = lseek(input.as_fd(), 0, Whence::SeekCur) else {
let input_pos = lseek(input.as_fd(), 0, Whence::SeekCur);
let output_pos = lseek(output.as_fd(), 0, Whence::SeekCur);
if is_appending(output) {
if let Ok(pos) = input_pos {
if pos >= 0 && (pos as u64) >= file_size {
return false;
}
}
return true;
}
let Ok(input_pos) = input_pos else {
return false;
};
let Ok(output_pos) = lseek(output.as_fd(), 0, Whence::SeekCur) else {
let Ok(output_pos) = output_pos else {
return false;
};
input_pos < output_pos
Expand Down
Loading