Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cakebaker
Copy link
Contributor

This PR fixes two "constant is never used" warnings that show up on Android (see, for example, https://github.com/uutils/coreutils/actions/runs/19028332358/job/54336353070?pr=9126#step:16:2026):

warning: constant `SUB_FILE` is never used
   --> tests/by-util/test_du.rs:26:7
    |
 26 | const SUB_FILE: &str = "subdir/links/subwords.txt";
    |       ^^^^^^^^
    |
    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default

warning: constant `SUB_LINK` is never used
   --> tests/by-util/test_du.rs:28:7
    |
 28 | const SUB_LINK: &str = "subdir/links/sublink.txt";
    |       ^^^^^^^^

There are also two "unused import" warnings shown in the link above. I left them, as they are related to #7542

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 3, 2025

CodSpeed Performance Report

Merging #9131 will improve performances by 2.93%

Comparing cakebaker:du_fix_dead_code_in_test (88d2dfe) with main (d2f6996)

Summary

⚡ 1 improvement
✅ 124 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
du_human_balanced_tree[(5, 4, 10)] 10.4 ms 10.1 ms +2.93%

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@RenjiSann RenjiSann merged commit 80de3ae into uutils:main Nov 3, 2025
121 checks passed
@RenjiSann
Copy link
Collaborator

nice ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants