Revert "Fix base64 benchmarks" #9139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 975e18c.
CodSpeed Performance ReportMerging #9139 will improve performances by ×3,100Comparing Summary
Benchmarks breakdown
|
|
GNU testsuite comparison: |
Contributor
|
@sylvestre My bad, I thought it's okay to add an output flag to the interface. I didn't really see a straightforward way to redirect stdout any other way. The only way I see is spawning a new process and doing the stdout redirect as the tests are doing with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, I merged it too quickly.
Please do it without touching the interface of the command. Ie we don't want -o in base64.
Please do it with redirect of the stdout ">"
Reverts #9082