Fix test job in FreeBSD workflow #9155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove wrong flag '-p uucore' for 'cargo metadata' command to get features. Signed-off-by: Laurent Cheylus <[email protected]>
|
GNU testsuite comparison: |
Contributor
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #8483 (add
feat_systemd_logindfeature), jobtestin FreeBSD workflow was modified to disable tests forfeat_systemd_logindfeature (not supported on FreeBSD). But thecargo metadatacommand is wrong =>-p uucoredoes not exist.UUCORE_FEATURES=\$(cargo metadata --format-version=1 --no-deps -p uucore | jq -r '.packages[] | select(.name == "uucore") | .features | keys | .[]' | grep -v "feat_systemd_logind" | paste -s -d "," -)There are some errors when running
testjob in FreeBSD workflow (but not trapped by the shell script). For example in this run of FreeBSD workflow (https://github.com/uutils/coreutils/actions/runs/19094908884/job/54553168173#step:5:8891):error: unexpected argument '-p' foundFix in
.github/workflows/freebsd.yml: remove wrong flag-p uucoreforcargo metadatacommand to get features.Tests OK => see this run in my personal fork, https://github.com/lcheylus/rust-coreutils/actions/runs/19126450509