Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix build and tests for uptime on OpenBSD #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

Fix build and tests for uptime on OpenBSD #9158

merged 2 commits into from
Nov 7, 2025

Conversation

@lcheylus
Copy link
Contributor

@lcheylus lcheylus commented Nov 6, 2025

Fix #9157

Build for uptime OK on OpenBSD current/amd64 with Rust 1.90.0

$ cargo build -v --no-default-features --features uptime
(...)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.11s

$ ./target/debug/coreutils uptime
 10:58:57  up  7 days 22:44,  1 user,  load average: 0.21, 0.49, 0.75
$ ./target/debug/coreutils uptime -s
2025-10-29 12:14:06
$ ./target/debug/coreutils uptime && guptime
 10:59:30  up  7 days 22:45,  1 user,  load average: 0.25, 0.47, 0.73
 10:59:30  up 7 days 22:45,  1 user,  load average: 0.25, 0.47, 0.73

Tests for uptime OK on OpenBSD current/amd64 with Rust 1.90.0

$ cargo test -v --no-default-features --features uptime
(...)
running 7 tests
test test_uptime::test_invalid_arg ... ok
test test_uptime::test_uptime_check_users_openbsd ... ok
test test_uptime::test_uptime ... ok
test test_uptime::test_uptime_with_dir ... ok
test test_uptime::test_uptime_with_extra_argument ... ok
test test_uptime::test_uptime_with_non_existent_file ... ok
test test_uptime::test_uptime_since ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s

@oech3
Copy link
Contributor

oech3 commented Nov 6, 2025

@cakebaker Conflics with your #7256 ?

@cakebaker
Copy link
Contributor

cakebaker commented Nov 6, 2025

@oech3 it's possible, though my PR is work in progress anyway.

@lcheylus lcheylus mentioned this pull request Nov 7, 2025
Closed
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #9158 will degrade performances by 2.55%

Comparing lcheylus:openbsd-uptime (7b1fbc0) with main (5b79ae4)

Summary

❌ 1 regression
✅ 124 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ du_human_balanced_tree[(5, 4, 10)] 10.1 ms 10.4 ms -2.55%

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit ad1bac4 into uutils:main Nov 7, 2025
120 of 121 checks passed
@sylvestre
Copy link
Contributor

sylvestre commented Nov 7, 2025

Merci Laurent ! :)

@oech3
Copy link
Contributor

oech3 commented Nov 8, 2025

Can this repo bump rust used at CI to 1.90+ from 1.85?

@cakebaker
Copy link
Contributor

cakebaker commented Nov 8, 2025

@oech3 in the CI we already use Rust stable for most jobs. What you probably mean is the MSRV (minimum supported Rust version), which currently is 1.85.0. Increasing this value is more "difficult" because other projects depend on this project. For example, ubuntu is switching to uutils coreutils and they use Rust 1.85.0 afaik. What's the reason you want to see a bump?

@oech3
Copy link
Contributor

oech3 commented Nov 8, 2025 via email

@lcheylus lcheylus deleted the openbsd-uptime branch November 8, 2025 07:38
@lcheylus
Copy link
Contributor Author

lcheylus commented Nov 8, 2025

Because this issue(PR) and an issue is 1.90 specific and not detected by CI. (and newer ver uses fast linker by default.)

This error is not detected by CI because there is no CI for OpenBSD (work that's been in progress for a long time that I need to finish...).

@oech3
Copy link
Contributor

oech3 commented Nov 8, 2025 •
edited
Loading

Oops... Maybe, we can start CI from make UTILS="uptime true false"

This was referenced Nov 8, 2025
Closed
Merged
asder8215 pushed a commit to asder8215/coreutils that referenced this pull request Nov 8, 2025
@lcheylus @asder8215
Fix build and tests for uptime on OpenBSD (uutils#9158)
53f025f 
* uptime: fix build errors on OpenBSD

Signed-off-by: Laurent Cheylus <[email protected]>

* tests: fix error for uptime on OpenBSD

Signed-off-by: Laurent Cheylus <[email protected]>

---------

Signed-off-by: Laurent Cheylus <[email protected]>
naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Nov 8, 2025
@lcheylus @naoNao89
Fix build and tests for uptime on OpenBSD (uutils#9158)
9f6b3d9 
* uptime: fix build errors on OpenBSD

Signed-off-by: Laurent Cheylus <[email protected]>

* tests: fix error for uptime on OpenBSD

Signed-off-by: Laurent Cheylus <[email protected]>

---------

Signed-off-by: Laurent Cheylus <[email protected]>
naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Nov 9, 2025
@lcheylus @naoNao89
Fix build and tests for uptime on OpenBSD (uutils#9158)
c1c9bfc 
* uptime: fix build errors on OpenBSD

Signed-off-by: Laurent Cheylus <[email protected]>

* tests: fix error for uptime on OpenBSD

Signed-off-by: Laurent Cheylus <[email protected]>

---------

Signed-off-by: Laurent Cheylus <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Nov 10, 2025
Merged
@moonfruit moonfruit mentioned this pull request Nov 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build errors for uptime on OpenBSD

4 participants

@lcheylus @oech3 @cakebaker @sylvestre