Align base64 with GNU base64.pl tests #9194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Nov 8, 2025
c7421e6 to
6e2a58d
Compare
|
GNU testsuite comparison: |
6e2a58d to
bc6bd60
Compare
CodSpeed Performance ReportMerging #9194 will improve performances by 3.1%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
GNU testsuite comparison: |
Contributor
|
well done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU’s tests/basenc/base64.pl revealed that our base64 decoder rejected streams where = appeared before EOF. This change updates the shared base logic to detect padding anywhere in the input, teaches the SIMD decoder to process padded and unpadded segments sequentially, and adds unit coverage for the concatenated cases.
#9127