basenc: Fix basenc.pl GNU-compat tests pass #9203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you please add tests to make sure we don't regress in the future? |
|
GNU testsuite comparison: |
Contributor
Author
|
Added the tests. Thanks for the feedback! |
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 9, 2025
cakebaker
reviewed
Nov 9, 2025
cakebaker
reviewed
Nov 9, 2025
Adds the GNU-style auto-padding/truncated cases to tests/by-util/test_basenc.rs and rewrites the failure assertions to use the chained fails().stdout_*(…).stderr_is(…) style for clarity.
Updates util/build-gnu.sh to stop forcing those two basenc tests to expect empty stdout, so the GNU suite again checks for the leaked five bytes before failure.
sylvestre
reviewed
Nov 10, 2025
Introduce PadResult, trim/pad incomplete base32 chunks, emit decoded prefixes, and still return error: invalid input in line with GNU basenc.
6209c9b to
99d1f73
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates basenc’s base32/base32hex decoder to auto-pad trailing quanta, stream output safely, and reject garbage the same way GNU does. Existing by-util basenc/base32 tests already cover these scenarios.
Removed the old note about data-encoding’s ignore flag because the new alphabet gatekeeper makes that rationale obsolete.
#9127