rm: overriding the libc call when implementation does not match gnu coreutils exactly#9604
Open
ChrisDryden wants to merge 4 commits intouutils:mainfrom
Open
rm: overriding the libc call when implementation does not match gnu coreutils exactly#9604ChrisDryden wants to merge 4 commits intouutils:mainfrom
ChrisDryden wants to merge 4 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
Contributor
|
sorry, it needs to be rebased |
0e464e9 to
9466d55
Compare
|
GNU testsuite comparison: |
This was referenced Jan 20, 2026
oech3
reviewed
Jan 20, 2026
| # spell-checker:ignore (paths) abmon deref discrim eacces getlimits getopt ginstall inacc infloop inotify reflink ; (misc) INT_OFLOW OFLOW | ||
| # spell-checker:ignore baddecode submodules xstrtol distros ; (vars/env) SRCDIR vdir rcexp xpart dired OSTYPE ; (utils) greadlink gsed multihardlink texinfo CARGOFLAGS | ||
| # spell-checker:ignore openat TOCTOU CFLAGS tmpfs gnproc | ||
| # spell-checker:ignore hfsplus casefold chattr dirp memcpy |
Contributor
|
need to be rebased |
9466d55 to
5ae2096
Compare
oech3
reviewed
Jan 20, 2026
| # * the selinux crate is handling errors | ||
| # * the test says "maybe we should not fail when no context available" | ||
| sed -i -e "s|returns_ 1||g" tests/cp/no-ctx.sh | ||
| "${SED}" -i -e "s|returns_ 1||g" tests/cp/no-ctx.sh |
CodSpeed Performance ReportMerging this PR will degrade performance by 15.3%Comparing Summary
Performance Changes
Footnotes
|
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally intended to be a demonstration for how we could modify the integration tests to recognize the libc calls we were using.
I discovered that I could wrap the implementation in this helper method to be able to address this tests in a relatively readable way compared to modifying the original code.
As it stands I believe there are three skipped tests in total right now that are skipped for this reason