fix: skip calculation when grid is hidden #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a resize or any event that triggers `iron-resize` happens as the Grid is about to hide, it may lead to some calculations to happen when the Grid is already hidden. That may lead to some misbehavior, like described on the linked issue. This fix checks the visibility status of the Grid to skip metrics calculation in case the Grid is not visible. fix #2127
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
reviewed
Jul 14, 2021
There was a problem hiding this comment.
Should this also be done for master branch or it is not relevant there?
It's not relevant because on |
DiegoCardoso
commented
Jul 14, 2021
| // When this happens, there might be some issues as described | ||
| // here https://github.com/vaadin/web-components/issues/2127. | ||
| // Skipping any calculation for a hidden Grid. | ||
| if (this.hidden) { |
There was a problem hiding this comment.
Here, I could also use _isVisible, which does return Boolean(this.offsetWidth || this.offsetHeight). Both works, but _isVisible is used in other places on the class, while hidden is not.
Suggested change
| if (this.hidden) { | |
| if (!this._isVisible) { |
web-padawan
approved these changes
Jul 14, 2021
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Jul 14, 2021
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Jul 14, 2021
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Jul 14, 2021
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Jul 15, 2021
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Jul 15, 2021
4 tasks
DiegoCardoso
added a commit
that referenced
this pull request
Aug 2, 2021
This is a complementary fix of #2244. The original fix works when Grid is directly set to hidden, but fails for other cases, eg. when a Grid's parent get hidden instead. This change uses iron-list`s _isVisible to check Grid's visibility to determine whether any further calculation should be skipped or not. Related to #2127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resize or any event that triggers
iron-resizehappens as the Grid is about to hide, it may lead to some calculations to happen when the Grid is already hidden. That may lead to some misbehavior, like described on the linked issue.This fix checks the visibility status of the Grid to skip metrics calculation in case the Grid is not visible.
Fixes #2127
Type of change