-
Notifications
You must be signed in to change notification settings - Fork 510
Restore use of cache mounts #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Restore use of cache mounts #1613
Conversation
673786f
to
af7e713
Compare
Pull Request Test Coverage Report for Build 4774368844
💛 - Coveralls |
This will need buildah 1.26 available in the runner. |
Download the latest artifacts for this pull request here: |
7c65a36
to
76d0963
Compare
@dcermak it looks like the version of buildah on the Ubuntu runners work with the mount cache. When I tested this before with https://github.com/vagrant-libvirt/vagrant-libvirt/actions/runs/3147154713/jobs/5116377272 I got the impression that the buildah version wasn't quite new enough and thought 1.26 would be required. However looking through the history of https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md I'm not seeing any indication that buildah was changed in the mean time, nor when I put up a test workflow did it appear that the version had moved on from 1.23.1. Since it's a bit unclear why it started to work before a new minor release, wondering if you could check this PR change locally to make sure I'm not re-introducing something that will break for other distros where buildah is in use? I've checked it locally and I'm still seeing the same error as before and I'm running 22.04 myself, so I'm a bit wary now of what buildah is actually in the runners. |
@dcermak never mind, I just spotted my mistake, forgot to update buildah to use the correct ref given I've moved the workflow to use |
76d0963
to
957d509
Compare
Ok, I got confused 😅 because it builds fine with buildah 1.27 on my machine. |
4b50a00
to
dc62ed4
Compare
dc62ed4
to
6dac218
Compare
Adjust syntax used for cache mounts to align with a format supported by both buildah and docker.
A docker image containing the code from this plugin to allow testing locally without installing If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1613 |
Adjust syntax used for cache mounts to align with a format supported
by both buildah and docker.