Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent error on windows virtiofs mount #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Prevent error on windows virtiofs mount #1793

wants to merge 10 commits into from

Conversation

z0rb
Copy link

@z0rb z0rb commented Dec 25, 2023

After installing WinFSP and the virtiofs driver in the provisioning phase, then configuring the service to autostart with sc config VirtioFsSvc binPath="C:\Program Files\Virtio-Win\VioFS\virtiofs.exe" start=auto depend=VirtioFsDrv ... the virtiofs share gets mounted as a separate drive in Windows 10.
Guide: https://github.com/virtio-win/kvm-guest-drivers-windows/wiki/Virtiofs:-Shared-file-system#setup-with-installer

image

I have no experience writing vagrant plugins. In my fork I have just tried to implement a NOOP so that the libvirt plugin doesn't error out because of the missing guest capability. This works for me as vagrant up succeeds and the share works properly.

Question for maintainers. Would this be ok to merge into main, to prevent the error? The capability obviously exists, but I do not know what would be acceptable for main.

@github-actions GitHub Actions
Copy link

A docker image containing the code from this plugin to allow testing locally without installing
can be pulled from: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1793-slim

If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1793

@z0rb
Copy link
Author

z0rb commented Dec 25, 2023

As a detail, the box I am using was build from the main branch of: https://github.com/ruzickap/ansible-role-virtio-win
With the addition of the following tasks:

  tasks:
    - name: Download WinFSP
      win_get_url:
        url: https://github.com/winfsp/winfsp/releases/download/v2.0/winfsp-2.0.23075.msi
        dest: "%HOMEDRIVE%\\winfsp.msi"
      register: result
      until: result is succeeded

    - name: Install WinFSP
      win_command: msiexec /i winfsp.msi /qn
      args:
        chdir: C:\

    - name: Download VirtioFS
      win_get_url:
        url: https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/latest-virtio/virtio-win-guest-tools.exe
        dest: "%HOMEDRIVE%\\virtio-win-guest-tools.exe"
      register: result
      until: result is succeeded
      
    - name: Install VirtioFS
      win_command: virtio-win-guest-tools.exe -s
      args:
        chdir: C:\

    - name: Configure VirtioFS Service
      win_command: sc config VirtioFsSvc binPath="C:\Program Files\Virtio-Win\VioFS\virtiofs.exe" start=auto depend=VirtioFsDrv

z0rb added 6 commits February 19, 2024 14:11
@z0rb
Merge branch 'vagrant-libvirt:main' into main
20928f3
@z0rb
Update Gemfile
8ab922c 
* Add s3 plugin here instead of sed-ing during install.
* Add log4r missing when building standalone.
@z0rb
Update Gemfile
64f6e7e 
* Redirect this branch to own fork
@z0rb
Create Gemfile.lock
cf92a0d 
* Attempt adding Gemfile.lock
@z0rb
Delete Gemfile.lock
468ddb2
@z0rb
Revert Update Gemfile
3d85b76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@z0rb