Remove config unsupported by fog-libvirt #1835
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fog-libvirt dropped support for libvirt < 1.2.8 in version v0.13.0 This config is no longer supported nor needed
…upported by system ruby
|
A docker image containing the code from this plugin to allow testing locally without installing If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1835 |
|
@electrofelix anything that speaks against merging this? Ty :-) |
ekohl
reviewed
Jan 5, 2025
| @@ -26,8 +26,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency 'xml-simple' | |||
| s.add_runtime_dependency 'diffy' | |||
|
|
|||
| # Make sure to allow use of the same version as Vagrant by being less specific | |||
| s.add_runtime_dependency 'nokogiri', '~> 1.6' | |||
| s.add_runtime_dependency 'nokogiri', '< 1.16' | |||
There was a problem hiding this comment.
Why pin this to < 1.16 while the latest version is 1.18?
|
I saw this same issue in the Debian autopkgtest runs, so I included 5bb08ec as a patch: https://ci.debian.net/packages/v/vagrant-libvirt/testing/amd64/58775988/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fog-libvirt dropped support for libvirt < 1.2.8 in version v0.13.0 This config is no longer supported nor needed
This call generates a warning
Fixes #1831