feat(isMobilePhone): add support for Gibraltar (en-GI) locale#2670
Open
abhu85 wants to merge 1 commit intovalidatorjs:masterfrom
Open
feat(isMobilePhone): add support for Gibraltar (en-GI) locale#2670abhu85 wants to merge 1 commit intovalidatorjs:masterfrom
abhu85 wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Add mobile phone validation for Gibraltar with support for: - Mobile series 54-59 (8 digits) - Mobile series 510, 522 (8 digits) - Mobile series 5250-5251 (8 digits) - Mobile series 6010-6011 (8 digits) Based on Gibraltar's official numbering plan. Rescues stale PR validatorjs#2520 by rebasing changes onto current master. Original author: @xKarinSan Co-Authored-By: Claude Opus 4.6 <[email protected]> Co-Authored-By: xKarinSan <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2670 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2592 2592
Branches 660 660
=========================================
Hits 2592 2592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add mobile phone validation support for Gibraltar (en-GI locale).
Changes
en-GIregex pattern toisMobilePhone.jssupporting:Background
This PR rescues the stale PR #2520 by @xKarinSan which had merge conflicts preventing merge. The original implementation has been rebased onto current master with the following fixes:
$anchor at end of regex to prevent partial matchesTest Plan
References
Co-Authored-By: xKarinSan [email protected]