feat(isCreditCard): add Maestro and InstaPayment card support#2671
Open
abhu85 wants to merge 1 commit intovalidatorjs:masterfrom
Open
feat(isCreditCard): add Maestro and InstaPayment card support#2671abhu85 wants to merge 1 commit intovalidatorjs:masterfrom
abhu85 wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Add validation support for: - Maestro cards (prefixes 5018, 5020, 5038, 6304, 6759, 6761, 6763) - InstaPayment cards (prefixes 637, 638, 639) Both card types are added as individual providers with proper tests. Rescues stale PR validatorjs#1701 (4.5 years old) by rebasing changes onto current code structure. The original PR used a single regex approach, but the codebase has since evolved to use individual provider regexes, so this implementation follows the current pattern. Original author: @avaly Co-Authored-By: Claude Opus 4.6 <[email protected]> Co-Authored-By: avaly <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2671 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2592 2592
Branches 660 660
=========================================
Hits 2592 2592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add credit card validation support for Maestro and InstaPayment card types.
Changes
maestrocard pattern toisCreditCard.jssupporting prefixes: 5018, 5020, 5038, 6304, 6759, 6761, 6763 (12-19 digits total)instapaymentcard pattern supporting prefixes: 637, 638, 639 (16 digits total)Background
This PR rescues the stale PR #1701 by @avaly (4.5 years old) which had merge conflicts.
The original PR used a single combined regex approach, but since then the codebase has evolved to use individual provider regexes in a
cardsobject. This implementation follows the current code pattern while preserving the original validation logic.Test Plan
Card Specifications
Maestro:
InstaPayment:
References
Co-Authored-By: avaly [email protected]