-
Notifications
You must be signed in to change notification settings - Fork 5
Minimal Documentation Changes #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
Signed-off-by: Jeremy Parr-Pearson <[email protected]>
| * Connection package as low-level abstraction across multiple drivers ([Valkey GLIDE](https://github.com/valkey-io/valkey-glide), [Lettuce](https://github.com/lettuce-io/lettuce-core), and [Jedis](https://github.com/redis/jedis)). | ||
| * Exception translation to Spring's portable Data Access exception hierarchy for driver exceptions. | ||
| * `ValkeyTemplate` that provides a high level abstraction for performing various Valkey operations, exception translation and serialization support. | ||
| * Pubsub support (such as a MessageListenerContainer for message-driven POJOs). | ||
| * Valkey Sentinel and Valkey Cluster support. | ||
| * Reactive API using Lettuce. | ||
| * JDK, String, JSON and Spring Object/XML mapping serializers. | ||
| * JDK Collection implementations on top of Valkey. | ||
| * Atomic counter support classes. | ||
| * Sorting and Pipelining functionality. | ||
| * Dedicated support for SORT, SORT/GET pattern and returned bulk values. | ||
| * Valkey implementation for Spring cache abstraction. | ||
| * Automatic implementation of `Repository` interfaces including support for custom finder methods using `@EnableValkeyRepositories`. | ||
| * CDI support for repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a rebranding of the existing Redis feature list. Wasn't sure which items to remove or alter.
| While updating dependencies and adding new configurations must be done manually, the renaming of packages and classes can be automated with a script. Here's an example using `sed`: | ||
|
|
||
| ```bash | ||
| find path/to/project -type f \( -name "*.java" -o -name "*.properties" -o -name "*.yml" \) -exec sed -i \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to come up with a comprehensive script since there are so many classes, and some things like dependency management and Spring configuration are not simple replacements. But I was able to use this command to get most of the way there by updating package names and most class names when I was testing migration of a few example projects.
Summary
Updated top-level
README.md(changed fromadoctomd, and updated to reflect Valkey instead of Redis), removed Redis-specificCONTRIBUTING.adocandSECURITY.adoc, and addedMIGRATION.md.This PR closes #7.
Testing
Tested following the migration guide steps for some custom examples, as well as a set of Spring Data Redis examples.
Current limitations:
Next Steps
Next up is to rebrand/rewrite the full documentation (see
src/main/antora). This will require aligning with how other Valkey documentation is generated and published.