Thanks to visit codestin.com
Credit goes to github.com

Skip to content

useOpenTelemetry and OpenTelemetry config inside the configuration #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Maayanshani25 merged 3 commits into from
Jan 19, 2026
Merged

useOpenTelemetry and OpenTelemetry config inside the configuration #41

Maayanshani25 merged 3 commits into from
Jan 19, 2026

Conversation

@Maayanshani25
Copy link
Collaborator

@Maayanshani25 Maayanshani25 commented Dec 31, 2025

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@Maayanshani25 Maayanshani25 force-pushed the useOpenTelemetry branch 2 times, most recently from 93eb028 to 6d5bc9f Compare December 31, 2025 12:33
@Maayanshani25 Maayanshani25 force-pushed the useOpenTelemetry branch 4 times, most recently from cbc1008 to 248ff6b Compare January 8, 2026 09:32
@jeremyprime jeremyprime changed the title useOpenTelementry and OpenTelemetry config inside the configuration useOpenTelemetry and OpenTelemetry config inside the configuration Jan 15, 2026
jeremyprime
jeremyprime reviewed Jan 15, 2026
View reviewed changes
jeremyprime
jeremyprime reviewed Jan 15, 2026
View reviewed changes
jeremyprime
jeremyprime reviewed Jan 16, 2026
View reviewed changes
ikolomi
ikolomi reviewed Jan 18, 2026
View reviewed changes
ikolomi
ikolomi reviewed Jan 18, 2026
View reviewed changes
ikolomi
ikolomi reviewed Jan 18, 2026
View reviewed changes
ikolomi
ikolomi requested changes Jan 18, 2026
View reviewed changes
Copy link
Collaborator

@ikolomi ikolomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. resolve comments
  2. Add section to the main readme https://github.com/valkey-io/spring-data-valkey/blob/main/README.md

@ikolomi ikolomi added the enhancement New feature or request label Jan 18, 2026
@ikolomi ikolomi added this to the Beta 0.2.0 milestone Jan 18, 2026
@Maayanshani25 Maayanshani25 force-pushed the useOpenTelemetry branch 2 times, most recently from ff0accd to e71f32e Compare January 19, 2026 07:07
@Maayanshani25 Maayanshani25 force-pushed the useOpenTelemetry branch 2 times, most recently from 5b09d67 to 976e197 Compare January 19, 2026 07:45
@Maayanshani25 Maayanshani25 force-pushed the useOpenTelemetry branch 3 times, most recently from 67dcefb to ece8c4a Compare January 19, 2026 08:36
@Maayanshani25
fixes
eb43288 
Signed-off-by: Maayan Shani <[email protected]>
@Maayanshani25
Add tests
26d88b1 
Signed-off-by: Maayan Shani <[email protected]>
@Maayanshani25 Maayanshani25 merged commit 41ee078 into valkey-io:main Jan 19, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyprime jeremyprime jeremyprime left review comments

@ikolomi ikolomi ikolomi requested changes

Assignees

@Maayanshani25 Maayanshani25

Labels

enhancement New feature or request

Projects

None yet

Milestone

Beta 0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Maayanshani25 @jeremyprime @ikolomi