Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Audio alerts intensity#279

Merged
valterc merged 4 commits intomainfrom
audio-alerts-intensity
Jan 11, 2025
Merged

Audio alerts intensity#279
valterc merged 4 commits intomainfrom
audio-alerts-intensity

Conversation

@valterc
Copy link
Owner

@valterc valterc commented Jan 11, 2025

Closes #271

@valterc valterc requested a review from Copilot January 11, 2025 16:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • app/src/main/java/com/valterc/ki2/karoo/audio/AudioIntensity.kt: Language not supported
  • app/src/main/java/com/valterc/ki2/karoo/audio/AudioManager.kt: Language not supported
  • app/src/main/java/com/valterc/ki2/update/post/actions/KarooAudioAlertsUpdateAction.kt: Language not supported
  • app/src/main/res/values/arrays.xml: Language not supported
  • app/src/main/res/values/preferences_global.xml: Language not supported
  • app/src/main/res/xml/preferences_audio_alerts.xml: Language not supported
Comments suppressed due to low confidence (2)

app/src/main/java/com/valterc/ki2/update/post/PostUpdateActions.java:26

  • Ensure that the new KarooAudioAlertsUpdateAction is covered by tests.
preInitActionMap.put(KarooAudioAlertsUpdateAction.class.getSimpleName(), new KarooAudioAlertsUpdateAction());

app/src/main/java/com/valterc/ki2/data/preferences/PreferencesView.java:336

  • The method getAudioAlertIntensity should be covered by tests to ensure it handles all possible input values correctly.
public AudioIntensity getAudioAlertIntensity(Context context) {

@valterc valterc merged commit 1b4d43b into main Jan 11, 2025
1 check passed
@valterc valterc deleted the audio-alerts-intensity branch January 11, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add options for old vs new audio alerts

1 participant