enhancement(host_metrics source): replace heim with sysinfo for load/host metrics#24819
Open
mushrowan wants to merge 1 commit intovectordotdev:masterfrom
Open
enhancement(host_metrics source): replace heim with sysinfo for load/host metrics#24819mushrowan wants to merge 1 commit intovectordotdev:masterfrom
mushrowan wants to merge 1 commit intovectordotdev:masterfrom
Conversation
…t metrics replace heim::cpu::os::unix::loadavg, heim::host::uptime, and heim::host::boot_time with sysinfo::System static methods. removes heim unit imports (ratio, second) from mod.rs
Contributor
Author
|
spellcheck issue is handled in #24818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace heim with sysinfo for load average, uptime, and boot time in the
host_metrics source. part of removing the unmaintained heim dependency (#23646)
heim::cpu::os::unix::loadavg()->System::load_average()heim::host::uptime()->System::uptime()heim::host::boot_time()->System::boot_time()all three sysinfo methods are static, sync, and infallible so the error handling
arms are removed
Vector configuration
How did you test this PR?
cargo test -p vector --no-default-features --features sources-host_metrics \ -- sources::host_metrics::tests::generates_loadavg_metrics \ sources::host_metrics::tests::generates_host_metricsChange Type
Is this a breaking change?
Does this PR include user facing changes?
guidelines.
no-changeloglabel to this PR.References
Notes