fix(docker_logs source): Update hyper to work around the docker EOF errors#5561
fix(docker_logs source): Update hyper to work around the docker EOF errors#5561
Conversation
…rrors Signed-off-by: MOZGIII <[email protected]>
|
@binarylogic As discussed. |
| [patch.'https://github.com/tower-rs/tower'] | ||
| tower-layer = "0.3" | ||
|
|
||
| [patch.crates-io] |
There was a problem hiding this comment.
We should add a comment here explaining what we need to bump hyper at some point.
There was a problem hiding this comment.
Indeed - I'd also like to wait to merge this until we verify that it's the solution. I think based on our morning detective work it is but if its at all possible to avoid merging an unnecessary crate patch that would be my preference.
There was a problem hiding this comment.
We can merge the patch and then switch to the released version. If we merge it the solution will be in the nightly and it'll be easier to test. We'll have to bump to publushed version either way, but we're imo in a good position to work with such patches.
I'll add a comment, and will merge if you agree.
We can already move from a fork to the upstream git since my PR (hyperium/hyper#2363) was accepted.
…rrors (#5561) Signed-off-by: MOZGIII <[email protected]>
This PR fixes (or rather is supposed to be fixing) the issue with docker that was reported earlier today.
Once merged, we'd want to backport it to 0.11 and ship with 0.11.1.
This is a hotfix, a proper resolution will be to simply bump the hyper once they cut a release.