Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(typing): Resolve multiple @utils.use_signature issues #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 6, 2024
Merged

fix(typing): Resolve multiple @utils.use_signature issues #3565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
53057b7
fix(typing): Handle methods & functions in `use_signature`
dangotbanned Sep 1, 2024
95ecb73
chore(typing): Remove fixed ignore comments
dangotbanned Sep 1, 2024
dbdc5d2
refactor: Drop `use_signature` for `FacetMapping`
dangotbanned Sep 1, 2024
e7fceb6
fix(typing): Exclude `core.FacetMapping` in favor of `api.FacetMapping`
dangotbanned Sep 1, 2024
044a814
refactor(typing): Rewrite with generic aliases
dangotbanned Sep 2, 2024
fb1fe81
fix: Resolve pre-3.11 bug
dangotbanned Sep 2, 2024
73b39ac
Merge remote-tracking branch 'upstream/main' into fix-use-signature-2
dangotbanned Sep 3, 2024
a258c53
Merge branch 'main' into fix-use-signature-2
dangotbanned Sep 4, 2024
7193d03
Merge branch 'main' into fix-use-signature-2
dangotbanned Sep 5, 2024
aa4d9e1
Merge branch 'main' into fix-use-signature-2
dangotbanned Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(typing): Exclude core.FacetMapping in favor of api.FacetMapping 
Now `mypy` can understand the symbol, it started complaining
  • Loading branch information
@dangotbanned
dangotbanned committed Sep 1, 2024
commit e7fceb6c004324b2b4e63823104020408b92b788
1 change: 0 additions & 1 deletion altair/vegalite/v5/schema/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@
"ExtentTransform",
"FacetEncodingFieldDef",
"FacetFieldDef",
"FacetMapping",
"FacetSpec",
"FacetedEncoding",
"FacetedUnitSpec",
Expand Down
2 changes: 1 addition & 1 deletion tools/generate_schema_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ def generate_vegalite_schema_wrapper(schema_file: Path) -> str:
# of exported classes which are also defined in the channels or api modules which takes
# precedent in the generated __init__.py files one and two levels up.
# Importing these classes from multiple modules confuses type checkers.
EXCLUDE = {"Color", "Text", "LookupData", "Dict"}
EXCLUDE = {"Color", "Text", "LookupData", "Dict", "FacetMapping"}
it = (c for c in definitions.keys() - EXCLUDE if not c.startswith("_"))
all_ = [*sorted(it), "Root", "VegaLiteSchema", "SchemaBase", "load_schema"]

Expand Down