Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add decimal place support #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add decimal place support #125

wants to merge 4 commits into from

Conversation

almandsky
Copy link

@almandsky almandsky commented Oct 20, 2019 •
edited
Loading

As per #124

Here is the PR to add decimal place support. Default is 0, max decimal place is 3.

ms(60000, { decimal: 1 })                           // "1m"
ms(66000, { decimal: 1 })                           // "1.1m"
ms(-3 * 66000, { long: true, decimal: 1 })          // "-3.3 minutes"
ms(234234234, { decimal: 2  })                      // "2.71m"
ms(ms('10.5 hours'), { long: true, decimal: 1 })    // "10.5 hours"

@ianmcderp ianmcderp mentioned this pull request Jul 23, 2020
Open
@yomed yomed mentioned this pull request Oct 4, 2020
Closed
@mahnunchik
Copy link

ping

christopher-caldwell
christopher-caldwell reviewed May 14, 2021
View reviewed changes
index.js
* @return {String}
* @api private
*/

function fmtLong(ms) {
function fmtLong(ms, demical) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be decimal, right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm yeah

@shwarcu
Copy link

shwarcu commented Jul 26, 2022 •
edited
Loading

@leerob @gmattie any chance for having this functionality added?

@XaaRii
Copy link

XaaRii commented Dec 1, 2024

Is there literally any chance of this being implemented? I use it for years now, works flawlessly but it's a bit of hassle to always remember and look for the correct fork every time. It shouldn't even have any breaking features, only adding a one new (and quite useful one imho).

@dimitropoulos
Copy link
Collaborator

@XaaRii what fork have you been using that has this?

@XaaRii
Copy link

XaaRii commented Jul 30, 2025 •
edited
Loading

@XaaRii what fork have you been using that has this?

That's a good question...
I found some backup files (I'm on vacation atm) and guessing by the package.json file, I seem to be using a fork from repo zeit/ms (version 2.1.2). I could be mistaken though, it's a long time since I set that project up and didn't follow general good practices back then.

edit: okay, zeit/ms seems to be the official repository of ms, my bad. I have the files of it, the author of it just didn't change/update their package.json to point to their own repo... I can probably find it in a browser history or something, I'll try to look it up.

@XaaRii
Copy link

XaaRii commented Jul 30, 2025

okay, after consulting my browser history, it's very likely almandsky's fork with his PR - specifically the sc/decimal_place branch. Makes sense.

https://github.com/almandsky/ms/tree/sc/decimal_place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
6 more reviewers

@christopher-caldwell christopher-caldwell christopher-caldwell left review comments

@orderatransfem orderatransfem orderatransfem left review comments

@gmattie gmattie gmattie approved these changes

@groudjulien groudjulien groudjulien approved these changes

@ianmcderp ianmcderp ianmcderp approved these changes

@shwarcu shwarcu shwarcu approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@almandsky @mahnunchik @shwarcu @XaaRii @dimitropoulos @gmattie @groudjulien @ianmcderp @christopher-caldwell @orderatransfem