Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document req and res #16432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2020
Merged

Document req and res #16432

merged 3 commits into from
Aug 22, 2020

Conversation

sharils
Copy link
Contributor

@sharils sharils commented Aug 21, 2020

No description provided.

lfades
lfades previously approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharils Thank you! 💯

lfades
lfades approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after fixing lint issues 😅

@ijjk
Copy link
Member

ijjk commented Aug 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary sharils/next.js patch-2 Change
buildDuration 12.6s 12.8s ⚠️ +206ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary sharils/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.346 2.339 -0.01
/ avg req/sec 1065.63 1068.91 +3.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.428 1.271 -0.16
/error-in-render avg req/sec 1750.33 1966.34 +216.01
Client Bundles (main, webpack, commons)
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..07ae.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sharils/next.js patch-2 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sharils/next.js patch-2 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary sharils/next.js patch-2 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary sharils/next.js patch-2 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary sharils/next.js patch-2 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary sharils/next.js patch-2 Change
buildDuration 13.7s 14.2s ⚠️ +532ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..07ae.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sharils/next.js patch-2 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sharils/next.js patch-2 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary sharils/next.js patch-2 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary sharils/next.js patch-2 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary sharils/next.js patch-2 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 9abc841

@ijjk
Copy link
Member

ijjk commented Aug 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary sharils/next.js patch-2 Change
buildDuration 12.8s 12.8s -42ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary sharils/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.44 2.481 ⚠️ +0.04
/ avg req/sec 1024.39 1007.58 ⚠️ -16.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.558 1.474 -0.08
/error-in-render avg req/sec 1605.03 1696.36 +91.33
Client Bundles (main, webpack, commons)
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..07ae.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sharils/next.js patch-2 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sharils/next.js patch-2 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary sharils/next.js patch-2 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary sharils/next.js patch-2 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary sharils/next.js patch-2 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary sharils/next.js patch-2 Change
buildDuration 15.4s 14.7s -786ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..07ae.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sharils/next.js patch-2 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sharils/next.js patch-2 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sharils/next.js patch-2 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary sharils/next.js patch-2 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary sharils/next.js patch-2 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary sharils/next.js patch-2 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 27df0ba

@lfades lfades merged commit 120b41e into vercel:canary Aug 22, 2020
@sharils sharils deleted the patch-2 branch August 23, 2020 09:17
@sharils
Copy link
Contributor Author

sharils commented Aug 23, 2020

Oops, sorry for the lint error :(

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharils @ijjk @lfades