Update max-age in HSTS sample #27452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous paragraph mentions a max-age of 2 years, so the number of seconds should match.
|
Whoops, I think it was supposed to be 1 year. I don't think you can set a max age longer than a year (I could be wrong). |
|
@leerob this does look correct, seems 2 years is valid now but the limit used to be 1 year per the MDN doc we link https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Strict-Transport-Security#examples |
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
The previous paragraph mentions a max-age of 2 years, so the number of seconds should match.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous paragraph mentions a max-age of 2 years, so the number of seconds should match.
Documentation / Examples