Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(fetch-cache): add check for updated tags when checking same cache key #63547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 9, 2024
Merged

fix(fetch-cache): add check for updated tags when checking same cache key #63547

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a9a3520
fix(fetch-cache): add check for updated tags when checking same cache…
samcx Mar 21, 2024
98ff8fa
fix(fetch-cache): removing unnecessary 'FETCH' check
samcx Mar 21, 2024
2cd7f6c
fix(fetch-cache): re-add 'FETCH' check
samcx Mar 21, 2024
53030bc
fix(fetch-cache): add minor tweaks
samcx Mar 21, 2024
858b4a0
Merge branch 'canary' into sam/fix-fetch-cache-tags
samcx Mar 21, 2024
1b804ef
fix(fetch-cache): add suggested changes
samcx Mar 26, 2024
d48182d
fix(fetch-cache): add more suggested changes
samcx Mar 27, 2024
0ca80ab
Merge branch 'canary' into sam/fix-fetch-cache-tags
samcx Mar 27, 2024
bd79373
Merge branch 'canary' into sam/fix-fetch-cache-tags
samcx Apr 5, 2024
c85bd30
Merge branch 'canary' into sam/fix-fetch-cache-tags
samcx Apr 5, 2024
b7a5a33
fix(fetch-cache): add test
samcx Apr 5, 2024
c2f985a
fix(fetch-cache): remove comments
samcx Apr 5, 2024
76e9425
test(fetch-cache): update test title
samcx Apr 5, 2024
c83128b
test(fetch-cache): update test
samcx Apr 5, 2024
4f5179e
test(fetch-cache): add force-dynamic
samcx Apr 5, 2024
e83e602
test(fetch-cache): fix test
samcx Apr 5, 2024
f3f7bc6
test(fetch-cache): switch to force-cache
samcx Apr 5, 2024
499568b
Merge branch 'canary' into sam/fix-fetch-cache-tags
samcx Apr 9, 2024
c48ce41
fix(fetch-cache): add suggested changes
samcx Apr 9, 2024
947fa92
test(app-static): add another test that revalidatetag's as well
samcx Apr 9, 2024
dce5b09
Merge branch 'canary' into sam/fix-fetch-cache-tags
samcx Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(fetch-cache): re-add 'FETCH' check
  • Loading branch information
@samcx
samcx committed Mar 21, 2024
commit 2cd7f6c84fa4d324924d9f8027bed411e42c79c8
4 changes: 3 additions & 1 deletion packages/next/src/server/lib/incremental-cache/fetch-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ export default class FetchCache implements CacheHandler {
}

// if new tags were specified, merge those tags to the existing tags
cached.tags = [...new Set([...(cached.tags ?? []), ...(tags ?? [])])]
if (cached.kind === 'FETCH') {
cached.tags = [...new Set([...(cached.tags ?? []), ...(tags ?? [])])]
}

const cacheState = res.headers.get(CACHE_STATE_HEADER)
const age = res.headers.get('age')
Expand Down