Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: mixing namespace import and named import client components #64809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2024
Merged

fix: mixing namespace import and named import client components #64809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6f6373
repro
huozhi Apr 19, 2024
abf2bdc
fix: mixing wildcard import and named import client components
huozhi Apr 19, 2024
2e67d24
merge namespace and named imports into *
huozhi Apr 21, 2024
a36b73b
refactor
huozhi Apr 21, 2024
b965f85
rename
huozhi Apr 21, 2024
a56105d
add more test
huozhi Apr 21, 2024
5fdcc14
explain
huozhi Apr 21, 2024
6bc015b
Merge branch 'canary' into fix/tree-shaking-import-wildcard
huozhi Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename
  • Loading branch information
@huozhi
huozhi committed Apr 21, 2024
commit b965f85460354e1b2fea503518a4c35c479d98ec
0 ...wildcard/client-wildcard/client-module.js → ...-namespace/client-module/client-module.js
View file
Open in desktop
File renamed without changes.
0 ...-import-wildcard/client-wildcard/index.js → ...t-import-namespace/client-module/index.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...haking/app/client-import-wildcard/page.js → ...aking/app/client-import-namespace/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as clientMod from './client-wildcard'
import { ClientModExportC } from './client-wildcard'
import * as clientMod from './client-module'
import { ClientModExportC } from './client-module'

const map = {
...clientMod,
Expand Down
4 changes: 2 additions & 2 deletions test/production/app-dir/client-components-tree-shaking/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ createNextDescribe(
expect($('p').text()).toContain('client:mod-export-default')
})

it('should handle mixing wildcard imports and named imports from client components', async () => {
const $ = await next.render$('/client-import-wildcard')
it('should handle mixing namespace imports and named imports from client components', async () => {
const $ = await next.render$('/client-import-namespace')

expect($('#a').text()).toContain('client:mod-export-a')
expect($('#b').text()).toContain('client:mod-export-b')
Expand Down