fix(next-config-ts): Resolve compilerOptions from extends (#74888) #74914
+90
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
6e6a57b to
ca17754
Compare
|
Thank you for the PR! Could you write an E2E test? |
8b58076 to
03cd9d2
Compare
|
@devjiwonchoi Fixed a possible infinite loop when reading through my initial code. I'm not very familiar with writing e2e tests for stuff like this, but hope it suffices. If you have any suggestions/improvements, let me know, I'd be happy to include them! |
bce2860 to
c7f0d92
Compare
|
@devjiwonchoi Bumping to check if this suffices |
c7f0d92 to
465fe71
Compare
|
@leerob Could you maybe take a look? |
465fe71 to
2deddf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
lazilyGetTSConfigto try and resolve compilerOptions from extends in tsconfig files. Fixes #74888