[Turbopack] Fix AST traversal for this in function default parameters
#83746
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include FunctionField::Params in the AST traversal check to correctly identify when `this` appears within a function's scope. Previously only checked FunctionField::Body, missing `this` usage in default parameters. Fixes vercel#83739
CodSpeed Performance ReportMerging #83746 will create unknown performance changesComparing Summary
Footnotes
|
|
@mischnic would you be able to take a look at this, hopefully this is a fairly trivial PR to get reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include FunctionField::Params in the AST traversal check to correctly identify when
thisappears within a function's scope. Previously only checked FunctionField::Body, missingthisusage in default parameters.Fixes #83739