Resolve request ID confusion #85809
Merged
Resolve request ID confusion #85809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the cache status for a page in dev mode is a sequential operation that only requires the HTML request ID to identify WebSocket clients across different browser tabs/windows. This is different from connecting the React debug channel (after which the cache status handling was modeled), which requires both the HTML request ID as well as the request ID to correctly associate debug chunks for a given client with the matching request, which might be for the HTML document, a client-side navigation, or a server function call. With this PR, we're removing the unused `requestId` parameter from the `setCacheStatus` function. We're also renaming the WebSocket client's request ID to `htmlRequestId`, as well as renaming the associated maps and variables accordingly. This avoids confusion and better reflects the purpose of these IDs. One of those confusions was apparent in the `setReactDebugChannel` methods, which is now cleared up as well.
Tests Passed |
eps1lon
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the cache status for a page in dev mode is a sequential operation that only requires the HTML request ID to identify WebSocket clients across different browser tabs/windows. This is different from connecting the React debug channel (after which the cache status handling was modeled), which requires both the HTML request ID as well as the request ID to correctly associate debug chunks for a given client with the matching request, which might be for the HTML document, a client-side navigation, or a server function call.
With this PR, we're removing the unused
requestIdparameter from thesetCacheStatusfunction. We're also renaming the WebSocket client's request ID tohtmlRequestId, as well as renaming the associated maps and variables accordingly.This avoids confusion and better reflects the purpose of these IDs. One of those confusions was apparent in the
setReactDebugChannelmethods, which is now cleared up as well.